Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.reflex-dom-core: Remove obsolete patches #103239

Merged
merged 1 commit into from Nov 10, 2020
Merged

haskellPackages.reflex-dom-core: Remove obsolete patches #103239

merged 1 commit into from Nov 10, 2020

Conversation

maralorn
Copy link
Member

@maralorn maralorn commented Nov 9, 2020 •
edited

Motivation for this change

Those patches don‘t apply anymore, because they have been merged upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@maralorn
Copy link
Member Author

maralorn commented Nov 9, 2020

Giving this into review because the remaining override is kinda ugly … But it was like that before and the bug has not been fixed upstream, so I guess we can leave it like that.

Although I‘d had apreciated my past self to write a slightly more verbose comment on what exactly failed, if we would mark the package unbroken …

@maralorn
Copy link
Member Author

maralorn commented Nov 9, 2020

Result of nixpkgs-review pr 103239 1

1 package built:
  • neuron-notes

cdepillabout
cdepillabout approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this up!

@maralorn maralorn merged commit 3a914a4 into NixOS:haskell-updates Nov 10, 2020
@maralorn maralorn deleted the fix-reflex-dom-core branch November 10, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maralorn @cdepillabout