Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asterisk: Bump all packages #103201

Merged
merged 1 commit into from Nov 9, 2020
Merged

asterisk: Bump all packages #103201

merged 1 commit into from Nov 9, 2020

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Nov 9, 2020

Motivation for this change

Packages were out of date

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from yorickvP and DerTim1 November 9, 2020 11:49
@dasJ dasJ requested a review from ajs124 November 9, 2020 11:53
@dasJ dasJ added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 9, 2020
@ajs124
Copy link
Member

ajs124 commented Nov 9, 2020

What do you think about adding yourself as maintainer to this? Since you've been adding new branches, removing old ones and just doing general maintenance on this, lately?

@dasJ
Copy link
Member Author

dasJ commented Nov 9, 2020

Idk. I have no idea on how to configure/use Asterisk, I just provide the package for someone else to use and configure (as you know). I don't think I'm the right person to maintain this. Maybe ask again in 3 releases or so :D

@yorickvP
Copy link
Contributor

yorickvP commented Nov 9, 2020

I also don't currently use asterisk. I may again in the future, but for now, maybe we should find a user.

@ajs124 ajs124 merged commit 147a03b into NixOS:master Nov 9, 2020
@ajs124 ajs124 deleted the bump/asterisk branch November 9, 2020 18:29
@ajs124 ajs124 restored the bump/asterisk branch November 9, 2020 18:29
@ajs124 ajs124 deleted the bump/asterisk branch November 9, 2020 18:29
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103201 run on x86_64-linux 1

5 packages built:
  • asterisk (asterisk-lts ,asterisk-stable ,asterisk_18)
  • asterisk-module-sccp
  • asterisk_13
  • asterisk_16
  • asterisk_17

@erictapen
Copy link
Member

Backported in a7334d2.

@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorickvP yorickvP yorickvP approved these changes

@DerTim1 DerTim1 Awaiting requested review from DerTim1

@ajs124 ajs124 Awaiting requested review from ajs124

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dasJ @ajs124 @yorickvP @SuperSandro2000 @erictapen