Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] isso: build from master #103211

Merged
merged 1 commit into from Nov 18, 2020
Merged

[20.09] isso: build from master #103211

merged 1 commit into from Nov 18, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Nov 9, 2020

Motivation for this change

Backport of #97717, wasn't backported during ZHF: #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Enteee @fgaz
isso: build from master
c5ab663 
* The published 0.12.2 version is broken therefore switch to build from
master. Related Issue: isso-comments/isso#617
* cleanup build inputs
* use python3

(cherry picked from commit 85c0767)

+ unmark broken
@fgaz fgaz requested a review from jonringer November 17, 2020 20:49
jonringer
jonringer approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 103211 1

1 package built:
  • isso

@jonringer jonringer merged commit 1e3b3f0 into NixOS:release-20.09 Nov 18, 2020
@fgaz fgaz deleted the isso/unstable-20.09-backport branch November 18, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fgaz @jonringer @Enteee