podcast: init at 0.17.5 #103203
Closed
podcast: init at 0.17.5 #103203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvarWithoutBones
approved these changes
Nov 18, 2020
|
Result of 1 package built:
|
SuperSandro2000
requested changes
Nov 23, 2020
There was a problem hiding this comment.
Patch to get it building on darwin:
diff --git a/pkgs/tools/networking/podcast/default.nix b/pkgs/tools/networking/podcast/default.nix
index 8e4905e909e0..5c3357847cd6 100644
--- a/pkgs/tools/networking/podcast/default.nix
+++ b/pkgs/tools/networking/podcast/default.nix
@@ -1,4 +1,4 @@
-{ lib, fetchFromGitHub, rustPlatform, pkgconfig, openssl }:
+{ stdenv, fetchFromGitHub, rustPlatform, pkgconfig, openssl, darwin }:
rustPlatform.buildRustPackage rec {
pname = "podcast";
@@ -16,9 +16,10 @@ rustPlatform.buildRustPackage rec {
cargoPatches = [ ./cargo-lock.patch ];
nativeBuildInputs = [ pkgconfig ];
- buildInputs = [ openssl ];
+ buildInputs = [ openssl ]
+ ++ stdenv.lib.optionals stdenv.isDarwin (with darwin.apple_sdk.frameworks; [ Security ]);
- meta = with lib; {
+ meta = with stdenv.lib; {
description = "Command line podcast manager and player";
homepage = "https://github.com/njaremko/podcast";
license = licenses.gpl3Only;
Mic92
reviewed
Nov 23, 2020
djanatyn
force-pushed
the
pkg/podcast
branch
from
8ad7b5d
to
f9088f8
Compare
SuperSandro2000
requested changes
Dec 27, 2020
Comment on lines
+19
to
+20
| url = | ||
| "https://github.com/njaremko/podcast/commit/ecf96f79c765e36ca86f24dbdcc4a217914479eb.diff"; |
There was a problem hiding this comment.
Suggested change
| url = | |
| "https://github.com/njaremko/podcast/commit/ecf96f79c765e36ca86f24dbdcc4a217914479eb.diff"; | |
| url = "https://github.com/njaremko/podcast/commit/ecf96f79c765e36ca86f24dbdcc4a217914479eb.diff"; |
Comment on lines
+1
to
+2
| { stdenv, fetchpatch, fetchFromGitHub, rustPlatform, pkgconfig, openssl, darwin | ||
| }: |
There was a problem hiding this comment.
Suggested change
| { stdenv, fetchpatch, fetchFromGitHub, rustPlatform, pkgconfig, openssl, darwin | |
| }: | |
| { stdenv, fetchpatch, fetchFromGitHub, rustPlatform, pkg-config, openssl, Security }: |
Please do not input darwin.
| }) | ||
| ]; | ||
|
|
||
| nativeBuildInputs = [ pkgconfig ]; |
There was a problem hiding this comment.
Suggested change
| nativeBuildInputs = [ pkgconfig ]; | |
| nativeBuildInputs = [ pkg-config ]; |
| @@ -6495,6 +6495,8 @@ in | |||
|
|
|||
| podiff = callPackage ../tools/text/podiff { }; | |||
|
|
|||
| podcast = callPackage ../tools/networking/podcast { }; | |||
There was a problem hiding this comment.
Suggested change
| podcast = callPackage ../tools/networking/podcast { }; | |
| podcast = callPackage ../tools/networking/podcast { | |
| inherit (darwin.apple_sdk.frameworks) Security; | |
| }; |
|
|
||
| nativeBuildInputs = [ pkgconfig ]; | ||
| buildInputs = [ openssl ] ++ stdenv.lib.optionals stdenv.isDarwin | ||
| (with darwin.apple_sdk.frameworks; [ Security ]); |
There was a problem hiding this comment.
Suggested change
| (with darwin.apple_sdk.frameworks; [ Security ]); | |
| [ Security ]; |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Stalled. Most likely out-dated at this point. Please re-open if you interested in this package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Full featured podcast manager, similar to greg. Written in Rust!
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)