python3Packages.kaggle: 1.5.6 -> 1.5.9 #103204
Closed
+31
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumecherel
force-pushed
the
upgrade-kaggle
branch
from
eb52486 to
7e2b9c5
Compare
|
@guillaumecherel Do you want to add yourself as a maintainer for kaggle? |
|
I'd rather not, I'm not a regular user. |
jonringer
reviewed
Nov 10, 2020
Comment on lines
+3344
to
3350
| guillaumecherel = { | ||
| email = "guillaume.cherel@cosimus.com"; | ||
| github = "guillaumecherel"; | ||
| githubId = 6168820; | ||
| name = "Guillaume Chérel"; | ||
| }; | ||
| guillaumekoenig = { |
There was a problem hiding this comment.
Please make this into a separate commit:
maintainers: add <name>
There was a problem hiding this comment.
Nitpick: commit messages should not end with a dot.
guillaumecherel
force-pushed
the
upgrade-kaggle
branch
from
f650291 to
90b095a
Compare
SuperSandro2000
requested changes
Nov 24, 2020
Comment on lines
+3344
to
3350
| guillaumecherel = { | ||
| email = "guillaume.cherel@cosimus.com"; | ||
| github = "guillaumecherel"; | ||
| githubId = 6168820; | ||
| name = "Guillaume Chérel"; | ||
| }; | ||
| guillaumekoenig = { |
There was a problem hiding this comment.
Nitpick: commit messages should not end with a dot.
| description = "A generic slugifier utility, inspired by Django’s slugify template filter."; | ||
| license = licenses.unlicense; | ||
| platforms = platforms.all; | ||
| maintainers = with maintainers; [ ]; |
There was a problem hiding this comment.
Can you add yourself here, too?
| homepage = "https://github.com/zacharyvoase/slugify"; | ||
| description = "A generic slugifier utility, inspired by Django’s slugify template filter."; | ||
| license = licenses.unlicense; | ||
| platforms = platforms.all; |
There was a problem hiding this comment.
That is automatically set and only required if not all is supported.
| @@ -0,0 +1,19 @@ | |||
| { stdenv, fetchPypi, buildPythonPackage, python, text-unidecode }: | |||
There was a problem hiding this comment.
Suggested change
| { stdenv, fetchPypi, buildPythonPackage, python, text-unidecode }: | |
| { stdenv, fetchPypi, buildPythonPackage }: |
SuperSandro2000
changed the title
|
Master already contains the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Upgrade the kaggle command line API to its latest version.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)