pulseaudio: add hsphfpd support #103225
Merged
pulseaudio: add hsphfpd support #103225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
jtojnar
reviewed
Nov 9, 2020
|
Since |
As far as I understand, the AFAICT all combinations of pulseaudio-hsphfpd and hsphfpd should work (and most of them even make sense):
|
This make sense too. Original pulseaudio HSP code is buggy. My patches fixes this (legacy) HSP code to work correctly and is loaded when hsphfpd daemon is running. So if you do not need HFP and HSP is enough then you can use pulseaudio also without hsphfpd. |
|
I apologize if this is off-topic, but what would it take to get |
|
@jtojnar |
|
Just to give enough context: Pali's branch has added stuff to |
|
Looks like they might work on upstreaming it after pali’s patches are merged according to EHfive/pulseaudio-modules-bt#1. Hopefully, that will be in PA 15. |
|
I'll merge this PR as all comments have been addressed and this is a change that doesn't cause any rebuilds and shouldn't break anything. |
|
Note that @pali has deleted the fork on gitlab. |
|
I am also following the situation... I don't think we should make any rushed decisions. If you're concerned about the dead link in the pulseaudio-hsphfpd package in the meantime, we could change it to my fork instead. |
|
Thanks. @pali did you also work on mSBC codec support? |
|
What's the impact of this on closure size? It looks like it makes pulseaudio depend on |
|
The impact on closure size is zero. Applications only depend on the pulseaudio libraries ( |
|
I'm abusing this PR, but using the following configuration: {
hardware.pulseaudio.package = pkgs.pulseaudio-hsphfpd;
hardware.pulseaudio.enable = true;
hardware.bluetooth.hsphfpd.enable = true;
hardware.bluetooth.enable = true;
}I can observe the following outputBut |
|
|
|
It might be better to remove the service until there is an alternative that does actual UI things. |
May be useless in functionality but I'm pretty sure it's some required(?) part of the stack. It shouldn't be failing, or at least it didn't while I used it. |
|
I made an issue to further discuss the (potential) issue: #114222 It might include required parts of the stack, but currently it seems it is doing nothing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
HFP is a bluetooth protocol used for headsets with microphones. This PR packages an in-progress patch to pulseaudio that supports HFP using the new hsphfpd daemon.
Warning: missing codec support is a big pain point for now. You get microphone support, but only at 8kHz because the mSBC codec is not implemented yet. And
pulseaudio-modules-btdoesn't work, so there's no AAC/etc. support.To enable:
This is a reworked version of #101787. Thanks to @eadwu for doing all the work! cc @jtojnar
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)