Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python310: 3.10.0a1 -> 3.10.0a2 #103226

Merged
merged 1 commit into from Nov 12, 2020
Merged

python310: 3.10.0a1 -> 3.10.0a2 #103226

merged 1 commit into from Nov 12, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 9, 2020 •
edited

Motivation for this change

bump dev version

doesn't fix wheel installation sadly:

/build/coverage-5.2.1/dist /build/coverage-5.2.1
ERROR: coverage-5.2.1-cp310-cp310-linux_x86_64.whl is not a supported wheel on this platform.

no ld-config.patch need to be regenerated

cc @FRidh

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner November 9, 2020 18:39
@jonringer
Copy link
Contributor Author

tests are failing because wheels still can't be installed

@jonringer jonringer merged commit 5a51224 into NixOS:master Nov 12, 2020
@jonringer jonringer deleted the python310a2 branch November 12, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer