Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2ray: 4.31.0 -> 4.32.1 #103220

Merged
merged 1 commit into from Nov 20, 2020
Merged

v2ray: 4.31.0 -> 4.32.1 #103220

merged 1 commit into from Nov 20, 2020

Conversation

servalcatty
Copy link
Contributor

Motivation for this change
  1. According to README, v2ray/v2ray-core is moved to v2fly/v2ray-core. Urls are updated.
  2. Bump version.
  3. A new dependency introduced has an unfree license. Change the package license to unfree. (See also License issue of new dependency xtls library v2ray/v2ray-core#2789)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit November 9, 2020 17:37
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 11, 2020 •
edited

Result of nixpkgs-review pr 103220 run on x86_64-darwin 1

1 package failed to build:
  • v2ray

Edit: false negative...

@marsam marsam merged commit 2bdd0fc into NixOS:master Nov 20, 2020
@Loyalsoldier
Copy link

V2Ray v4.33.0 has removed XTLS, so it still be licensed under MIT.

https://github.com/v2fly/v2ray-core/releases/tag/v4.33.0

And BTW, you can change the official website of V2Ray to https://www.v2fly.org

@servalcatty
Copy link
Contributor Author

V2Ray v4.33.0 has removed XTLS

It's still a pre-release currenly. I'll look into it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@servalcatty @SuperSandro2000 @Loyalsoldier @marsam