FYI, wineStable 5.0.3 was released today as well, maybe that could also go into this update.

Yes, that sounds reasonable testing right now, will update here when my CPU is done 😴

Alright, had a successful build, pushed again for nix-review.

Also had to upgrade vst-sdk since I couldn't find the old sources any more in their dl page.

Can we include this update as well? would reduce the rebuilds needed, if it lands together. #102142

Issue while running nixpkgs-review on my end (still ongoing):

error: --- Error --- nix-daemon
builder for '/nix/store/h0gk3a0bq9piz2hz28rbd3pnkdwc3rm9-airwave-1.3.3.drv' failed with exit code 1; last 10 log lines:
  -- Detecting CXX compile features
  -- Detecting CXX compile features - done
  -- VSTSDK_PATH is set to /nix/store/65l493prjwzxvnj6dwyjh3jx1bbz4khi-vst-sdk_3.7.0_build-116_2020-07-31/VST2_SDK
  CMake Error at CMakeLists.txt:65 (message):
    VST SDK is not found.  You should set the VSTSDK_PATH variable to the
    directory, where your copy of the VST SDK is located.
  
  
  -- Configuring incomplete, errors occurred!
  See also "/build/source/build/CMakeFiles/CMakeOutput.log".

That's after downloading the SDK zip file by hand and adding it to the store as suggested by the requireFile builder. The nix store path exists and contains public.sdk, is that expected?

@ikervagyok Can do, but this is going to be hard on my CPU...

@SFrijters Yes, having that issue aswell. Working on a fix.

The rest is fine for me btw:

1 package failed to build:
airwave

19 package built:
lutris lutris-free lutris-unwrapped pipelight playonlinux protontricks wine wineStaging wineMinimal wineStable winePackages.fonts winePackages.staging wineUnstable wineWowPackages.base wineWowPackages.full wineWowPackages.minimal wineWowPackages.staging wineWowPackages.unstable winetricks

@SFrijters Can you tell me how the directory structure of vstsdk/VST2_SDK looked before my upgrade? I don't have the sources, so I can't check. Currently it's /nix/store/klij9p5z22p2j9m88va211ihn338dssq-vst-sdk_3.7.0_build-116_2020-07-31/VST2_SDK/public.sdk/source/vst2.x and then there are a bunch of header files in there.

@pstn you dont have to include it, but these kind of auxiliary updates often fall short for a long time. I'll try with the next wine-release if it's too much for your cpu/patience.

@pstn Unfortunately I don't have airwave on my system usually, so I don't have the old SDK sources in my store.
But maybe this helps: if I look at https://github.com/psycha0s/airwave the README consistently mentions VST3 instead of VST2, so maybe the fix is to set

- cmakeFlags = [ "-DVSTSDK_PATH=${vst-sdk}/VST2_SDK" ];
+ cmakeFlags = [ "-DVSTSDK_PATH=${vst-sdk}/VST3_SDK" ];

in airwave?

Already tried that to no avail.
I had a closer look at airwave and it seems like it's looking for the files aeffect.h aeffectx.h and can't find them because they aren't in the archive any more. Since that project seems to be on life support anyway, I propose to not upgrade vst-sdk and mark airwave as broken since it can't be built any more if you don't happen to have the right files.

I agree with not updating the sdk / marking airwave as broken.

But weirdly, the previous version used in nixpkgs seems to available still at https://www.steinberg.net/sdk_downloads/vstsdk366_27_06_2016_build_61.zip . So we could also revert back to that and put a comment. But it seems like a losing battle.

If I was working with airwave I rather had a warning because of a broken package with time to fix than something happening suddenly. If people already have that vstsdk version in their store, they can still build airwave and might have time to supply a proper fix themselves upstream.

@ikervagyok Added your wine-mono upgrade into this PR.

Would be nice to have it merged, becasue 5.22 is on the go (and it need patching of cert-path.patch, @dasJ I will need your advice here)

Huh? Doesn't the patch apply?

I don't think this pr should be applied any more. Why merge an out of support version. Let's just merge 5.22 directly instead. I'll have a look.

@dasJ It seems like that file changed a lot since the 5.21.

@pstn I mean add one more commit with 5.22 on top of this, or merge it and do 5.22 separately due rootcert issue.
I like to see all versions in history.

@dasJ they split reading root certs between rootcert.c and dlls/crypt32/unixlib.c

PS btw, I thinking about side repo, with auto updating all wines by hashes on their site (and by pushing to wine-staging probably) -- what you think about it?

Sounds like a flake that I would use and contribute to if possible. It seems like especially wine-unstable/staging moves to fast nowadays for nixpkgs to keep up without a commiter with a strong interest in it, as this PR kind of proves.

@pstn exactly. And also be easier to update/propagate staging to nixpkgs. Is pretty safe to update automatically (after 1day grace period maybe, if it broken in siderepo -- someone can jus "vetoing" merging, marking is as brownbag)

I made new branch with commits from there, and new 5.22 and updated cert-root.patch, now building. Will do new PR as soon as it builds (it take ~3 hours)

Superseded by #104719