Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: amaranth-lang/amaranth
base: ebbdac97987c
Choose a base ref
...
head repository: amaranth-lang/amaranth
compare: ea94c9cc45c1
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Nov 9, 2020

  1. hdl.rec: proxy operators correctly. 

    Commit abbebf8 used __getattr__ to proxy Value methods called on 
Record. However, that did not proxy operators like __add__ because
Python looks up the special operator methods directly on the class
and does not run __getattr__ if they are missing.

Instead of using __getattr__, explicitly enumerate and wrap every
Value method that should be proxied. This also ensures backwards
compatibility if more methods are added to Value later.

Fixes #533.
    @awygle
    awygle committed Nov 9, 2020
    Copy the full SHA
    ea94c9c View commit details
    Browse the repository at this point in the history