Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Record Operators #541

Merged
merged 3 commits into from Nov 9, 2020
Merged

Fix Record Operators #541

merged 3 commits into from Nov 9, 2020

Conversation

awygle
Copy link
Contributor

@awygle awygle commented Nov 9, 2020

Proxy Operator calls on Record through to Value implementation, using explicit enumeration to avoid depending on future changes to Value.

Fixes #533 .

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #541 (7ce4830) into master (ebbdac9) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
+ Coverage   81.33%   81.41%   +0.08%     
==========================================
  Files          49       49              
  Lines        6461     6462       +1     
  Branches     1289     1289              
==========================================
+ Hits         5255     5261       +6     
+ Misses       1016     1011       -5     
  Partials      190      190              
Impacted Files Coverage Δ
nmigen/hdl/rec.py 93.33% <100.00%> (+0.59%) ⬆️
nmigen/build/run.py 22.05% <0.00%> (ø)
nmigen/hdl/ast.py 89.62% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebbdac9...7ce4830. Read the comment docs.

@whitequark whitequark merged commit ea94c9c into amaranth-lang:master Nov 9, 2020
@whitequark
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change in Record
2 participants