Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvmPackages_latest: llvmPackages_10 -> llvmPackages_11 #103221

Merged
merged 2 commits into from Nov 9, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Nov 9, 2020

Motivation for this change

nixpkgs-review:

1 package added:
lldb_10 (init at 10.0.1)

11 packages updated:
bat-extras-prettybat clang-tools (10.0.1 → 11.0.0) cloudcompare google-cloud-cpp lldb (10.0.1 → 11.0.0) pdal python3.7-tiledb python3.8-tiledb tiledb vscode-extension-ms-vscode-cpptools vscode-extension-vscode-lldb

1 package removed:
lldb (†11.0.0)

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/michael/.cache/nixpkgs-review/rev-c743b16e70180d3b23540192a7834662a5e87e73-1/build.nix
builder for '/nix/store/2yxvnpr6hak2c9lyz2cxs67j2v3gkjkp-googleapis-cpp-cmakefiles-0.1.5.drv' failed with exit code 1; last 10 log lines:
  -- Generating done
  CMake Warning:
    Manually-specified variables were not used by the project:

      BUILD_TESTING
      CMAKE_EXPORT_NO_PACKAGE_REGISTRY
      CMAKE_POLICY_DEFAULT_CMP0025


  CMake Generate step failed.  Build files cannot be regenerated correctly.
cannot build derivation '/nix/store/illc2kyh6hycr08m6vw1ic8w8i2fwic6-google-cloud-cpp-0.14.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/54f6aibzwrv96mpcqlyd8yb58iilh1g5-env.drv': 1 dependencies couldn't be built
[16 built (1 failed), 371 copied (4271.4 MiB), 898.4 MiB DL]
error: build of '/nix/store/54f6aibzwrv96mpcqlyd8yb58iilh1g5-env.drv' failed
1 package failed to build:
google-cloud-cpp

11 packages built:
bat-extras.prettybat clang-tools cloudcompare lldb lldb_10 pdal python37Packages.tiledb python38Packages.tiledb tiledb vscode-extensions.ms-vscode.cpptools vscode-extensions.vadimcn.vscode-lldb
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from flokli and andir November 9, 2020 18:44
@primeos
Copy link
Member Author

primeos commented Nov 9, 2020

Should be fine (this is just a followup for #99984).

@primeos primeos merged commit 0519297 into NixOS:master Nov 9, 2020
@andir
Copy link
Member

andir commented Nov 10, 2020

Marking this a broken is fine. The derivation has always been a mess (due to how upstream handles packaging) and I only ever needed that for the now stalled GCS support for Nix…

@flokli
Copy link
Contributor

flokli commented Nov 11, 2020

I removed myself from the maintainers list in 7741f92, and personally think we should remove this, if it's known to be broken and noone is actively using it. This can still be resurrected from the history if someone wants to pick it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants