devour: init at 12 #103227
devour: init at 12 #103227
Conversation
pkgs/tools/X11/devour/default.nix
Outdated
|
|
||
| installPhase = '' | ||
| mkdir -p $out/local/usr/bin | ||
| mv devour $out/local/usr/bin |
There was a problem hiding this comment.
| mv devour $out/local/usr/bin | |
| install -Dm755 devour $out/usr/bin |
There was a problem hiding this comment.
That will give give you a devour executable named "bin" and we don't stick stuff in usr:
This is the right way:
install -Dm555 -t $out/bin devour
There was a problem hiding this comment.
I will change output to $out/bin and permissions to555, but I don't think that install command behaves like that. By default it copies compiled sources into destination, which is directory created by the command above (tested). Although I will change it anyway, as most of the other nix packages use install with -t.
pkgs/tools/X11/devour/default.nix
Outdated
| }; | ||
|
|
||
| installPhase = '' | ||
| mkdir -p $out/local/usr/bin |
There was a problem hiding this comment.
| mkdir -p $out/local/usr/bin | |
| mkdir -p $out/usr/bin |
pkgs/tools/X11/devour/default.nix
Outdated
| version = "12"; | ||
| name = "devour-${version}"; | ||
| src = fetchFromGitHub { | ||
| owner = "salman-abedin"; | ||
| repo = "devour"; | ||
| rev = version; | ||
| sha256 = "1qq5l6d0fn8azg7sj7a4m2jsmhlpswl5793clcxs1p34vy4wb2lp"; | ||
| }; |
There was a problem hiding this comment.
| version = "12"; | |
| name = "devour-${version}"; | |
| src = fetchFromGitHub { | |
| owner = "salman-abedin"; | |
| repo = "devour"; | |
| rev = version; | |
| sha256 = "1qq5l6d0fn8azg7sj7a4m2jsmhlpswl5793clcxs1p34vy4wb2lp"; | |
| }; | |
| pname = "devour"; | |
| version = "12"; | |
| src = fetchFromGitHub { | |
| owner = "salman-abedin"; | |
| repo = "devour"; | |
| rev = version; | |
| sha256 = "1qq5l6d0fn8azg7sj7a4m2jsmhlpswl5793clcxs1p34vy4wb2lp"; | |
| }; |
pkgs/tools/X11/devour/default.nix
Outdated
| meta = with stdenv.lib; { | ||
| description = "Devour hides your current window before launching an external program and unhides it after quitting."; | ||
| homepage = "https://github.com/salman-abedin/devour"; | ||
| maintainers = [ maintainers.mazurel ]; |
There was a problem hiding this comment.
| maintainers = [ maintainers.mazurel ]; | |
| maintainers = with maintainers; [ mazurel ]; |
There was a problem hiding this comment.
Why is this a problem? The full maintainer list doesn't need to be in scope when there's just one entry, no? Looks a lot cleaner the way it was before IMO
|
Please also split this into 2 commits - one with adding yourself to the maintainer list and the other being the devour package. |
|
Result of 1 package built:
|
pkgs/tools/X11/devour/default.nix
Outdated
| buildInputs = [ libX11 ]; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "Devour hides your current window before launching an external program and unhides it after quitting."; |
There was a problem hiding this comment.
meta.description should not end with a period, and this seems a bit long.
| description = "Devour hides your current window before launching an external program and unhides it after quitting."; | |
| description = "Devour hides your current window when launching an external program"; | |
| longDescription = "Devour hides your current window before launching an external program and unhides it after quitting"; |
|
Result of 1 package built:
|
|
Result of 1 package built:
|
Motivation for this change
Added devour, simple x11 tool that hides your current window before launching an external program.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)