Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign Features page #640

Merged
merged 95 commits into from Nov 25, 2020
Merged

Redesign Features page #640

merged 95 commits into from Nov 25, 2020

Conversation

garbas
Copy link
Member

@garbas garbas commented Nov 9, 2020

Highlights of the PR:

  • The page was renamed from Features to Overview
  • Page will focus to explain the benefits of using Nix/NixOS and not explaining how the features work. How the features work should be moved to Learn page (eg. Nix pills).

TODO

  • implement the design
  • come up with the content
  • add "How Nix works" page.
  • designer to redesign images once we have content

This change is Reviewable

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2020

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

Copy link
Member

@edolstra edolstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One thing that's missing is that we should highlight Nixpkgs as a feature.

BTW I'm not sure we should completely remove the more technical introduction from the old features pages. I tend to zone out reading marketing pages that promise great features without giving any idea of how it works...

overview.tt Outdated Show resolved Hide resolved
overview.tt Outdated Show resolved Hide resolved
overview.tt Outdated Show resolved Hide resolved
overview.tt Outdated Show resolved Hide resolved
overview.tt Outdated Show resolved Hide resolved
overview.tt Outdated Show resolved Hide resolved
overview.tt Outdated Show resolved Hide resolved
overview.tt Outdated Show resolved Hide resolved
overview.tt Outdated Show resolved Hide resolved
overview.tt Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

garbas and others added 4 commits November 12, 2020 12:13
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
@github-actions
Copy link
Contributor

garbas and others added 2 commits November 12, 2020 12:16
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@davidak
Copy link
Member

davidak commented Nov 17, 2020

Great page! I would love to share it after the update.

Screenshot from 2020-11-17 23-03-11

The blue buttons are completely unreadable. Should the last commit "links should be white" have fixed that?

How Nix works seem still to be the old page, so i haven't read it. Might be nice to add some images as well to make it more pleasant to read.

@github-actions
Copy link
Contributor

@garbas
Copy link
Member Author

garbas commented Nov 18, 2020

@davidak there was a typo in my last fix. links should be white now.

@davidak
Copy link
Member

davidak commented Nov 18, 2020

Except the images, it is good to merge.

@garbas garbas marked this pull request as ready for review November 23, 2020 21:53
@github-actions
Copy link
Contributor

@garbas garbas changed the title WIP: Redesign Features page Redesign Features page Nov 23, 2020
@davidak
Copy link
Member

davidak commented Nov 24, 2020

Some might consider it sexist and not inclusive/welcoming that there are only men on the website.

@garbas
Copy link
Member Author

garbas commented Nov 24, 2020

Some might consider it sexist and not inclusive/welcoming that there are only men on the website.

Yeah I had the same reaction. And the is also the racial component. I forgot to mention this to a designer and now we used the budget. I'll ask him if it is possible to change those men to some animals. Like we did with octopus for the donate page -> #647

@garbas
Copy link
Member Author

garbas commented Nov 24, 2020

Just talked to a developer. He will adjust the 3 graphics with animals.

@github-actions
Copy link
Contributor

@samueldr
Copy link
Member

TODO:

  • Verify lambdaflake colours.
  • Verify other colours, if they should match the palette or if deviation is desired.

@davidak
Copy link
Member

davidak commented Nov 25, 2020

arewefurriesyet.com -> yes

nice 😸

@garbas garbas merged commit 053ef7b into master Nov 25, 2020
@samueldr samueldr mentioned this pull request Nov 25, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants