lunar-client: init at version 2.4.0 #103229
Conversation
ofborg
bot
added
8.has: package (new)
There was a problem hiding this comment.
Please fix the commit naming and history. The last 3 fix-ups should be squashed into the package init commit and the entry in the maintainer-list is usually a stand-alone commit before your first packaging commit.
git reset --soft HEAD~5 # throws away last 5 commits' information without resetting file changes
git reset HEAD pkgs/games/lunar-client/default.nix # remove lunar-client from staging area
git commit # "maintainers: add zyansheep"
git add pkgs/games/lunar-client/default.nix
git commit # "lunar-client: init at 2.4.0"
git log
# when you think the git history looks good
git push -f
|
What else needs to be done to get this merged? |
|
Someone with merge permissions needs to see this PR and merge it, that's it really. Takes abit of patience and persistence to find someone sometimes, you can try posting a link to your reviewed PR here. |
|
Hmm... Seems like there needs to be a better way to add packages then to rely on a (relatively) small group of people to vet each and every one. Perhaps something like the Arch User Repository is needed? Maybe I'll open an rfc... |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
You're looking for the NUR then. |
|
Looks unfree to me, looks good to Borg :) |
Janik-Haag
added
the
12. first-time contribution
Motivation for this change
Lunar Client is a pretty popular minecraft client / launcher
Things done
sandboxinnix.confon non-NixOS linux)^^^ This is on by default on NixOS right?
nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)