Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dasel: 1.2.0 -> 1.5.0 #103219

Closed
wants to merge 1 commit into from
Closed

dasel: 1.2.0 -> 1.5.0 #103219

wants to merge 1 commit into from

Conversation

foo-dogsquared
Copy link
Member

Motivation for this change

Seems like the software is moving quickly so I updated it to catch up.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit and 0x4A6F November 9, 2020 17:20
0x4A6F
0x4A6F approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@0x4A6F 0x4A6F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs.
Thanks for stepping up as maintainer.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 11, 2020 •
edited

Result of nixpkgs-review pr 103219 run on x86_64-darwin 1

1 package failed to build:
  • dasel

Dependency fails to build

make: Entering directory '/private/tmp/nix-build-git-2.29.2.drv-0/git-2.29.2/contrib/subtree'
make -C ../../ GIT-VERSION-FILE
make[1]: Entering directory '/private/tmp/nix-build-git-2.29.2.drv-0/git-2.29.2'
make[1]: 'GIT-VERSION-FILE' is up to date.
make[1]: Leaving directory '/private/tmp/nix-build-git-2.29.2.drv-0/git-2.29.2'
install -d -m 755 /nix/store/77d2m64lhbvyn97frdwcbnc0zhj7m0w2-git-2.29.2/libexec/git-core
install -m 755 git-subtree /nix/store/77d2m64lhbvyn97frdwcbnc0zhj7m0w2-git-2.29.2/libexec/git-core
asciidoctor -b docbook -d manpage  \
        -agit_version=2.29.2 -I../../Documentation -rasciidoctor-extensions -alitdd='--' git-subtree.txt
`/homeless-shelter` is not a directory.
Bundler will use `/private/tmp/nix-build-git-2.29.2.drv-0/bundler20201111-92814-71hhjj92814' as your home directory temporarily.
Traceback (most recent call last):
        9: from /nix/store/jyrmsp8qf6g97rkm9vpg63295l8s3phy-asciidoctor-2.0.10/bin/asciidoctor:18:in `<main>'
        8: from /nix/store/8dv7qr9mmi9s1ggpkal7b4wp6x214q6f-bundler-2.1.4/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler.rb:149:in `setup'
        7: from /nix/store/8dv7qr9mmi9s1ggpkal7b4wp6x214q6f-bundler-2.1.4/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/runtime.rb:20:in `setup'
        6: from /nix/store/8dv7qr9mmi9s1ggpkal7b4wp6x214q6f-bundler-2.1.4/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/runtime.rb:101:in `block in definition_method'
        5: from /nix/store/8dv7qr9mmi9s1ggpkal7b4wp6x214q6f-bundler-2.1.4/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/definition.rb:226:in `requested_specs'
        4: from /nix/store/8dv7qr9mmi9s1ggpkal7b4wp6x214q6f-bundler-2.1.4/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/definition.rb:237:in `specs_for'
        3: from /nix/store/8dv7qr9mmi9s1ggpkal7b4wp6x214q6f-bundler-2.1.4/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/definition.rb:170:in `specs'
        2: from /nix/store/8dv7qr9mmi9s1ggpkal7b4wp6x214q6f-bundler-2.1.4/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/spec_set.rb:80:in `materialize'
        1: from /nix/store/8dv7qr9mmi9s1ggpkal7b4wp6x214q6f-bundler-2.1.4/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/spec_set.rb:80:in `map!'
/nix/store/8dv7qr9mmi9s1ggpkal7b4wp6x214q6f-bundler-2.1.4/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/spec_set.rb:86:in `block in materialize': Could not find nokogiri-1.10.3 in any of the sources (Bundler::GemNotFound)
make: *** [Makefile:86: git-subtree.xml] Error 1
make: Leaving directory '/private/tmp/nix-build-git-2.29.2.drv-0/git-2.29.2/contrib/subtree'
builder for '/nix/store/zxddfcgflyj3ilcnyasd3q56mjbsbwc7-git-2.29.2.drv' failed with exit code 2
cannot build derivation '/nix/store/79mn4xdy5f0ava23xzmcf6jni0q3x3d6-dasel-1.4.0-go-modules.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/n5m41z3lv2g0mlm053iackxp2b3ckcd9-dasel-1.4.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/n5m41z3lv2g0mlm053iackxp2b3ckcd9-dasel-1.4.0.drv' failed

@foo-dogsquared
Copy link
Member Author

Apologies for the noob questions as this is the first time I've contributed to nixpkgs.

  • How do I resolve the above error? Skimming from the build log, it seems it's an error from building Git.
  • Can I update the PR into a newer version while it is still unresolved? Case in point, the package has been updated at the time of this comment.

@0x4A6F
Copy link
Member

0x4A6F commented Nov 13, 2020 •
edited

  • Ping a person with access to this arch (x86_64-darwin): @SuperSandro2000 can you further debug this build for x86_64-darwin?
  • Yes, you can update the package in this pull request. just squash the commits and update the message and title.
    1.4.1 and 1.5.0 builds and runs on my local branch. If this is a problem with dasel on x86_64-darwin open a issue on the upstream project. But I think this is due to build dependency errors in nixpkgs on x86_64-darwin. You should also rebase your pull request to origin/master.

@SuperSandro2000
Copy link
Member

Git failed to build when you created your branch. Rebasing might fix this but I did not follow it lately to know it exactly.

@foo-dogsquared foo-dogsquared changed the title dasel: 1.2.0 -> 1.4.0 dasel: 1.2.0 -> 1.5.0 Nov 13, 2020
@ofborg ofborg bot requested a review from 0x4A6F November 13, 2020 17:51
@foo-dogsquared
Copy link
Member Author

I updated the PR now to the latest commit of the master branch (at least 35 minutes ago).

@foo-dogsquared
Copy link
Member Author

@SuperSandro2000 can you check if it successfully builds on x86_64-darwin?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103219 run on x86_64-darwin 1

1 package built:
  • dasel

@foo-dogsquared
Copy link
Member Author

Closing since #103859 already takes care of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4A6F 0x4A6F 0x4A6F approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@foo-dogsquared @SuperSandro2000 @0x4A6F @Janik-Haag