Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 8aaf2e60e544
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 32fdf2118ce7
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Nov 9, 2020

  1. ruby: Rename removeReferencesToCC flag to !jitSupport 

    If JIT support is built in to ruby, there's no choice other then to
leave this cc reference as is. removeReferencesToCC didn't do it's job
completely since some time ago. That's why it was practically redundant
- `lib/ruby/${version}/<platform>/rbconfig.rb` still referenced cc.
Removing this reference from
`lib/ruby/${version}/<platform>/rbconfig.rb` as well might lead to
breakage in some Gems that require this feature.

But, if JIT support is not desired, it should be safe enough to
completely remove all cc references, both in
lib/ruby/${version}/<platform>/rbconfig.rb and in $out/lib/libruby.so .
Hence now `rubyMinimal` has JIT support disabled and it has no
references at all to stdenv.cc.
    @doronbehar
    doronbehar committed Nov 9, 2020
    Copy the full SHA
    f59f043 View commit details
    Browse the repository at this point in the history

  2. rubyMinimal: remove 

    Due to being unused, and seemingly unusable, added appropriate release
notes.
    @doronbehar
    doronbehar committed Nov 9, 2020
    1
    Copy the full SHA
    9db44f6 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #90151 from doronbehar/ruby-gcc-ref

    @doronbehar
    doronbehar committed Nov 9, 2020
    Copy the full SHA
    32fdf21 View commit details
    Browse the repository at this point in the history