-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
audiofile: fix static build #103270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
audiofile: fix static build #103270
Conversation
c3d1e5e
to
bdb6acb
Compare
bdb6acb
to
6cdc03a
Compare
This works for me: diff --git a/pkgs/development/libraries/audiofile/default.nix b/pkgs/development/libraries/audiofile/default.nix
index 46c29e2fa12..4362aec7da6 100644
--- a/pkgs/development/libraries/audiofile/default.nix
+++ b/pkgs/development/libraries/audiofile/default.nix
@@ -28,6 +28,8 @@ stdenv.mkDerivation rec {
# fix build with gcc9
NIX_CFLAGS_LINK = lib.optional (stdenv.system == "i686-linux") "-lgcc";
+ LIBTOOL_FLAGS = lib.optionalString stdenv.targetPlatform.isStatic "-static";
+
patches = [
./gcc-6.patch
./CVE-2015-7747.patch
|
I suppose that line could even go into the adapter nixpkgs/pkgs/stdenv/adapters.nix Lines 46 to 48 in 2f75dec
|
Weird, doesn't work for me, I still have to keep both my hacks in |
Yeah, makes sense. |
My bad, LIBTOOLFLAGS doesn't seem to work for me either. I think it makes sense to return to the original commit minus the |
6cdc03a
to
c3b1e7e
Compare
done, thanks for the feedback :) |
Thanks! |
Fixes #103215
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)