Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LAStools: init at 201003 #103253

Merged
merged 2 commits into from Nov 23, 2020
Merged

LAStools: init at 201003 #103253

merged 2 commits into from Nov 23, 2020

Conversation

StephenWithPH
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@StephenWithPH StephenWithPH mentioned this pull request Nov 10, 2020
Closed
9 tasks
@sikmir
Copy link
Member

sikmir commented Nov 10, 2020 •
edited

@StephenWithPH Is it different tools than provided by libLAS?

$ ls /nix/store/h6dnqd73f805cvldsc7pvlxpmika1bkg-libLAS-1.8.1/bin/
las2col  las2las  las2pg  las2txt  lasblock  lasinfo  liblas-config  ts2las  txt2las

@StephenWithPH
Copy link
Contributor Author

StephenWithPH commented Nov 10, 2020 •
edited

@sikmir ...

Is it different tools than provided by libLAS?

Yes... for several reasons that I can tell.

  • libLAS points towards LAStools
  • LAStools seems to be the place to get command-line tools like LASzip.

IvarWithoutBones
IvarWithoutBones requested changes Nov 11, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions 👍

You should also squash the commits to just be one, with LAStools: init at 201003 as the commit message.

pkgs/development/libraries/LAStools/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/LAStools/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/LAStools/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/LAStools/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/LAStools/default.nix Show resolved Hide resolved
@StephenWithPH
Copy link
Contributor Author

@IvarWithoutBones

You should also squash the commits to just be one, with LAStools: init at 201003 as the commit message.

I plan to squash all of my commits. The origin of this PR was @mpickering 's work-in-progress; I think it's appropriate to preserve that for attribution. So there will end up being two commits in this PR.

While this remains a draft PR, I left all of the intermediate commits evolving from where I started to now in case anyone on the original PR (#45446) showed up in the comments.

@StephenWithPH StephenWithPH marked this pull request as ready for review November 12, 2020 21:56
@StephenWithPH
Copy link
Contributor Author

@SuperSandro2000 || @IvarWithoutBones ... bumping for review now that I've squashed per above.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103253 run on x86_64-darwin 1

1 package built:
  • LAStools

@SuperSandro2000 SuperSandro2000 merged commit edcd5cc into NixOS:master Nov 23, 2020
@StephenWithPH StephenWithPH deleted the add-las-tools branch November 23, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@IvarWithoutBones IvarWithoutBones IvarWithoutBones approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@StephenWithPH @sikmir @SuperSandro2000 @IvarWithoutBones @mpickering