-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
xorg.libX11: fix static build #103278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xorg.libX11: fix static build #103278
Conversation
Fix the incorrect linking of the build tool `makekeys` during the build process as described here NixOS#103195
Although this allows libX11 to build, I don't think it's built correctly. Things fail to link against libX11, missing some xcb symbols, for example in this test to detect X11: https://gist.github.com/expipiplus1/87201bd0f57325541a365ebf378415cc#file-gistfile1-txt-L5-L36 |
I had the same problem here: nixpkgs/pkgs/top-level/static.nix Lines 293 to 297 in 4aabac8
libx11 depends on libxcb, but the dependency is automatically followed by the linker only with shared libraries. With static linking, |
hmm, is there a good fix for this aside from just patching downstream packages? |
I'm not sure, maybe there is a way to merge libX11.a and libxcb.a into only one archive ? |
Or maybe we can have a look at what other static-only distros do ? |
The output of this derivation is correct, I think it would be quite weird to link libxcb in with libX11, likewise it would be pretty hacky to trick consumers of libX11 to link with libxcb using NIX_LDFLAGS or whatever. sadly I think that this is just a bug in dbus which should be fixed. Knowing what other distros do would be good, I'll have a quick look. |
Is it possible to merge this please as the above problem seems to be one with dbus's build system and not libX11 |
ping? |
Hmm I forgot about this and the file completely changed on master. |
On master pkgstStatic.xorg.libX11 builds. The particular change proposed here has been already applied. |
Great!
…On Thu, Mar 25, 2021, 6:01 PM Michele Guerini Rocco < ***@***.***> wrote:
On master pkgstStatic.xorg.libX11 builds. The particular change proposed
here has been already applied.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#103278 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGRJXBGT3MTP47Z2GEFIALTFMCXTANCNFSM4TQIU3CQ>
.
|
Fix the incorrect linking of the build tool
makekeys
during the buildprocess as described here #103195
Note: I have not tested this
CC @symphorien
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)