Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.FutureAsyncAwait: 0.45 -> 0.46 #103264

Merged
merged 1 commit into from Nov 12, 2020
Merged

perlPackages.FutureAsyncAwait: 0.45 -> 0.46 #103264

merged 1 commit into from Nov 12, 2020

Conversation

zakame
Copy link
Member

@zakame zakame commented Nov 10, 2020 •
edited

Motivation for this change

https://metacpan.org/release/PEVANS/Future-AsyncAwait-0.46

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zakame zakame requested a review from stigtsp as a code owner November 10, 2020 03:06
@stigtsp
Copy link
Member

stigtsp commented Nov 10, 2020

@volth is having ${version} in url ok for cpan2nix?

@stigtsp stigtsp requested a review from volth November 10, 2020 06:40
stigtsp
stigtsp approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 103264 1

2 packages built:
  • perl530Packages.FutureAsyncAwait
  • perl532Packages.FutureAsyncAwait

@stigtsp stigtsp merged commit 28a498b into NixOS:master Nov 12, 2020
@zakame
Copy link
Member Author

zakame commented Nov 12, 2020

Thanks! 🎉

@zakame zakame deleted the updates/perl-Future-AsyncAwait-0.46 branch November 12, 2020 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zakame @stigtsp