Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ngscopeclient/scopehal-apps
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2d2c6ee4e408
Choose a base ref
...
head repository: ngscopeclient/scopehal-apps
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5eaeae80cd85
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Nov 10, 2020

  1. Updated scopehal

    @azonenberg
    azonenberg committed Nov 10, 2020
    Copy the full SHA
    c7f8430 View commit details

  2. Fixed selection of last packet in protocol analyzer

    @azonenberg
    azonenberg committed Nov 10, 2020
    Copy the full SHA
    5eaeae8 View commit details
Showing with 5 additions and 7 deletions.
  1. +1 −1 lib
  2. +4 −6 src/glscopeclient/ProtocolAnalyzerWindow.cpp
2 changes: 1 addition & 1 deletion lib
Submodule lib updated 5 files
+83 −75 scopeprotocols/EyePattern.cpp
+3 −0 scopeprotocols/I2CEepromDecoder.cpp
+1 −0 scopeprotocols/SDCmdDecoder.cpp
+63 −5 scopeprotocols/SDDataDecoder.cpp
+7 −1 scopeprotocols/SDDataDecoder.h
10 changes: 4 additions & 6 deletions src/glscopeclient/ProtocolAnalyzerWindow.cpp
View file
Original file line number Diff line number Diff line change
@@ -569,12 +569,10 @@ void ProtocolAnalyzerWindow::OnWaveformDataReady()
last_packet = p;
}

//TODO: select the last row
//m_tree.get_selection()->select(*m);

//auto scroll to bottom
auto adj = m_scroller.get_vadjustment();
adj->set_value(adj->get_upper());
//Select the last row
auto path = m_model->get_path(*last_top_row);
m_tree.expand_to_path(path);
m_tree.scroll_to_row(path);

m_updating = false;
}