-
-
Notifications
You must be signed in to change notification settings - Fork 29
Separate workflows for creating release and publishing to JetBrains #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate workflows for creating release and publishing to JetBrains #19
Conversation
Since there was no change to the plugin since If you want to try the publication without merging the branch into |
I had to run the publish task from master, when running manually: |
Maybe we should just as a maintainer to the repository to debug this? |
The problem is that the ID of the plugin has been been changed from |
I created #20 to fix the issue. |
Looks like JetBrains/intellij-platform-gradle-plugin#507 has already fixed the issue of not showing the actual error message (without the |
Not sure what you wanted to say there. |
Maybe you should become a maintainer of this repository so you can fix this properly. |
I guess that is not necessary since we have fixed the issue. But thanks for considering it. Also before becomming an actual mmaintainer, I think I should become a more active user of Nix in general. |
This is an update for the release workflow(s). It addresses the issue of pull request #16 that you cannot re-run the step which publishes the release to JetBrains Marketplace. After this branch is merged, you can trigger the workflow Publish to JetBrains Marketplace manually without creating a new release.
I also changed the release process because releases created by GitHub Actions will not trigger any workflow. This means creating a release with GitHub Actions would not trigger the workflow which publishes the release to JetBrains Marketplace. To overcome this issue, the workflow Publish release is renamed to Prepare Release and will create drafts instead of actual releases. It will create a new draft whenever the master branch is updated. When you publish the draft as a release, GitHub tiggers the second workflow which publishes the release to JetBrains Marketplace.
Note that you shouldn't usually trigger Publish to JetBrains Marketplace manually. You should only trigger it manually if something was going wrong previously. If you want to publish a new version, you should create a new release instead.
As a caveat of this change, the binary for JetBrains Marketplace is build independently from the binary for the GitHub release. Since the build is not fully reproducible, both binaries may not be exactly the same. Anyway, both are build from the same sources.
PS: I got some inspiration from JetBrains/intellij-platform-plugin-template. While looking at this template, I already worked at some more improvments like bumping the version after the release. However, I wanted to fix the issue about the publication process first.