Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave: 1.15.76 -> 1.16.72 #103268

Merged
merged 1 commit into from Nov 13, 2020
Merged

brave: 1.15.76 -> 1.16.72 #103268

merged 1 commit into from Nov 13, 2020

Conversation

JeffLabonte
Copy link
Contributor

@JeffLabonte JeffLabonte commented Nov 10, 2020 •
edited

Motivation for this change

The browser needs to be up to be up-to-date at all time

Things done

Update version from 1.15.76 to 1.16.72

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from uskudnik and rht November 10, 2020 05:14
dbirks
dbirks approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@dbirks dbirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs nicely for me on NixOS. 👍

Just one nit that the commit message says 1.5.76 instead of 1.15.76. 🔍

@JeffLabonte JeffLabonte force-pushed the update/brave_1.15.76_to_1.16.72 branch from a1e3eea to 13e4f18 Compare November 11, 2020 13:46
@samueldr samueldr merged commit 5f936da into NixOS:master Nov 13, 2020
@JeffLabonte JeffLabonte mentioned this pull request Nov 13, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbirks dbirks dbirks approved these changes

@uskudnik uskudnik Awaiting requested review from uskudnik

@rht rht Awaiting requested review from rht

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JeffLabonte @dbirks @samueldr