Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

insomnia: 7.1.1 -> core@2020.4.2 #103251

Merged
merged 1 commit into from Dec 2, 2020
Merged

insomnia: 7.1.1 -> core@2020.4.2 #103251

merged 1 commit into from Dec 2, 2020

Conversation

mtrsk
Copy link
Member

@mtrsk mtrsk commented Nov 10, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

babariviere
babariviere approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@babariviere babariviere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SuperSandro2000
SuperSandro2000 reviewed Nov 10, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the unnecessary formatting changes? It makes the PR harder to review.

@mtrsk
Copy link
Member Author

mtrsk commented Nov 10, 2020 •
edited

Why the unnecessary formatting changes? It makes the PR harder to review.

Sorry, the only changes for now it's in the version/sha/url, the other divergences are due to running nixpkgs-fmt.

@SuperSandro2000
Copy link
Member

Sorry, the only changes for now it's in the version/sha/url, the other divergences are due to running nixpkgs-fmt.

I think they make it look worse especially with so many inputs. Can you please revert those parts?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103251 run on x86_64-linux 1

1 package built:
  • insomnia

@mtrsk
Copy link
Member Author

mtrsk commented Nov 24, 2020

Sorry, the only changes for now it's in the version/sha/url, the other divergences are due to running nixpkgs-fmt.

I think they make it look worse especially with so many inputs. Can you please revert those parts?

Sure, I should have done this earlier but forgot.

@ofborg ofborg bot requested a review from babariviere November 24, 2020 23:41
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103251 run on x86_64-linux 1

1 package built:
  • insomnia

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103251 run on x86_64-linux 1

1 package built:
  • insomnia

@SuperSandro2000 SuperSandro2000 merged commit 1963b5c into NixOS:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markus1189 markus1189 Awaiting requested review from markus1189

@babariviere babariviere Awaiting requested review from babariviere

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mtrsk @SuperSandro2000 @babariviere