Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libunwind: Add devman output #103250

Merged
merged 1 commit into from Dec 8, 2020
Merged

libunwind: Add devman output #103250

merged 1 commit into from Dec 8, 2020

Conversation

wentasah
Copy link
Contributor

@wentasah wentasah commented Nov 10, 2020

Installing the man pages is a bit more tricky. The configure script
completely disables the documentation unless latex2man is found.
However, just installing the man pages can be done without latex2man,
because the man pages are pre-built in the source tarball. Therefore
we pass ${coreutils}/bin/true as latex2man, which allows to install
the pre-build man pages without depending on full texlive.

Motivation for this change

It's useful to have the documentation matching the installed package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after) => No change
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Installing the man pages is a bit more tricky. The configure script
completely disables the documentation unless latex2man is found.
However, just installing the man pages can be done without latex2man,
because the man pages are pre-built in the source tarball. Therefore
we pass ${coreutils}/bin/true as latex2man, which allows to install
the pre-build man pages without depending on full texlive.
@FRidh FRidh changed the base branch from master to staging November 10, 2020 09:30
@FRidh FRidh added this to WIP in Staging via automation Nov 10, 2020
Staging automation moved this from WIP to Ready Nov 24, 2020
@FRidh FRidh merged commit b9116f7 into NixOS:staging Dec 8, 2020
Staging automation moved this from Ready to Done Dec 8, 2020
@wentasah wentasah deleted the libunwind-devman branch January 27, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants