Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/{loki,promtail}: better defaults #103289

Merged
merged 5 commits into from Nov 10, 2020
Merged

nixos/{loki,promtail}: better defaults #103289

merged 5 commits into from Nov 10, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 10, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from dasJ November 10, 2020 09:50
@Mic92 Mic92 changed the title nixo/loki: better defaults nixo/{loki,promtail}: better defaults Nov 10, 2020
@Mic92 Mic92 changed the title nixo/{loki,promtail}: better defaults nixos/{loki,promtail}: better defaults Nov 10, 2020
dasJ
dasJ approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@dasJ dasJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanges seem to be sensible

@Mic92 Mic92 merged commit 8cc52aa into NixOS:master Nov 10, 2020
@Mic92 Mic92 deleted the loki branch November 10, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ dasJ approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @dasJ