Fix stack overflow introduced in #4206 #4242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberth
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a stack overflow observed in
hydra-queue-runnerwhennixUnstable(updated to the latest master commit) is compiled without optimizations. It becomes a 100% CPU usage bug / deadlock when compiled with optimizations.I'm not entirely sure that the fix is correct because I don't know much about this code or even the Boost library, but it seems to work fine for me.
Comments NixOS/hydra#816 (comment) and NixOS/hydra#816 (comment) show example stack traces (you have to manually expand the comments because I've hidden them as off-topic, as it wasn't pertinent to that issue).
cc @roberth and @edolstra