python37Packages.onnx: 1.7.0 -> 1.8.0 #103286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested that |
acairncross
reviewed
Nov 10, 2020
Comment on lines
23
to
24
| # Due to Protobuf packaging issues this build of Onnx with Python 2 gives | ||
| # errors on import. |
There was a problem hiding this comment.
The next line of the comment (which I can't add a comment on directly) should be changed to something like # Support for Python 2 is deprecated as of Onnx v1.8. or I guess it could be omitted entirely.
There was a problem hiding this comment.
actually, it's already applied:
[nix-shell:~/.cache/nixpkgs-review/pr-103286]$ nix-build ./nixpkgs/ -A pythonPackages.onnx
error: onnx-1.8.0 not supported for interpreter python2.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python37Packages.onnx is: "Open Neural Network Exchange"
meta.homepage for python37Packages.onnx is: "http://onnx.ai"
meta.changelog for python37Packages.onnx is: ""
Updates performed
To inspect upstream changes
Impact
Checks done (click to expand)
built on NixOS
Warning: a test defined in
passthru.testsdid not pass0 of 0 passed binary check by having a zero exit code.
0 of 0 passed binary check by having the new version present in output.
found 1.8.0 with grep in /nix/store/m4f507c84yqvl9h7g06nzxq2s3bpsgvs-python3.7-onnx-1.8.0
directory tree listing: https://gist.github.com/e69b38c3ca7d5fb4ff1d1431aba27c72
du listing: https://gist.github.com/73b32d9d30b9004947eddf4ceb0403e9
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-review12 packages built:
Maintainer pings
cc @acairncross for testing.