Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/sshguard: only do ipv6 setup if enabled #104987

Merged
merged 1 commit into from Dec 11, 2020
Merged

nixos/sshguard: only do ipv6 setup if enabled #104987

merged 1 commit into from Dec 11, 2020

Conversation

peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Nov 26, 2020 •
edited

Motivation for this change

If ipv6 is not enabled, the firewall setup will fail when running iptables6.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg changed the title ###### Motivation for this change nixos/sshguard: only do ipv6 setup if enabled Nov 26, 2020
@peterhoeg peterhoeg merged commit aa995fb into NixOS:master Dec 11, 2020
@peterhoeg peterhoeg deleted the m/sshguard branch December 11, 2020 08:19
@peterhoeg peterhoeg restored the m/sshguard branch December 14, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@peterhoeg