Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.ParallelPipes: init at 0.005 #104975

Merged
merged 1 commit into from Nov 26, 2020
Merged

perlPackages.ParallelPipes: init at 0.005 #104975

merged 1 commit into from Nov 26, 2020

Conversation

zakame
Copy link
Member

@zakame zakame commented Nov 26, 2020

Motivation for this change

https://metacpan.org/release/Parallel-Pipes

Dependency for App::cpm

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zakame zakame requested a review from stigtsp as a code owner November 26, 2020 05:22
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104975 run on x86_64-linux 1

2 packages built:
  • perl530Packages.ParallelPipes
  • perl532Packages.ParallelPipes

stigtsp
stigtsp reviewed Nov 26, 2020
View reviewed changes
pkgs/top-level/perl-packages.nix Outdated
};
buildInputs = [ ModuleBuildTiny ];
meta = {
homepage = https://github.com/skaji/Parallel-Pipes;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage = https://github.com/skaji/Parallel-Pipes;
homepage = "https://github.com/skaji/Parallel-Pipes";

stigtsp
stigtsp approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 104975 1

2 packages built:
  • perl530Packages.ParallelPipes
  • perl532Packages.ParallelPipes

@stigtsp stigtsp merged commit cde94d8 into NixOS:master Nov 26, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104975 run on x86_64-darwin 1

2 packages built:
  • perl530Packages.ParallelPipes
  • perl532Packages.ParallelPipes

@zakame
Copy link
Member Author

zakame commented Nov 26, 2020

Thanks @stigtsp @SuperSandro2000 ! 🎉

@zakame zakame deleted the contrib/perl-Parallel-Pipes branch November 26, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zakame @SuperSandro2000 @stigtsp