Re-add missing canvas YAML tests #26650
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
AmeliaBR,
annevk,
domenic,
foolip,
fserb,
jdm,
jgraham,
kenrussell and
zqzhang
|
To be sure I understand: we didn't actually delete the files, just lost the ability to regenerate them from source, and that's why this change doesn't actually add any tests? |
|
That's correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26647
This re-adds the missing YAML canvas tests that were accidentally removed in #24099.
I modified the original YAML-splitting script used in #24099 to merge the input YAML files instead of overwriting them, and this was the result.
I did rebuild the canvas tests, but because these sources haven't been editable, nothing changed.