Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tor-browser-bundle-bin: 10.0.4 → 10.0.5 #104950

Merged
merged 1 commit into from Nov 26, 2020

Conversation

chkno
Copy link
Member

@chkno chkno commented Nov 26, 2020

Motivation for this change

Update to latest tor-browser-bundle-bin before the current version's src is removed & it fails to build (tor-browser-bundle-bin's src doesn't get cached in tarballs.nixos.org).

Also, this release includes fixes for these security vulnerabilities:

  • CVE-2020-26951: Parsing mismatches could confuse and bypass security sanitizer for chrome privileged code
  • CVE-2020-16012: Variable time processing of cross-origin images during drawImage calls
  • CVE-2020-26953: Fullscreen could be enabled without displaying the security UI
  • CVE-2020-26956: XSS through paste (manual and clipboard API)
  • CVE-2020-26958: Requests intercepted through ServiceWorkers lacked MIME type restrictions
  • CVE-2020-26959: Use-after-free in WebRequestService
  • CVE-2020-26960: Potential use-after-free in uses of nsTArray
  • CVE-2020-15999: Heap buffer overflow in freetype
  • CVE-2020-26961: DoH did not filter IPv4 mapped IP Addresses
  • CVE-2020-26965: Software keyboards may have remembered typed passwords
  • CVE-2020-26966: Single-word search queries were also broadcast to local network
  • CVE-2020-26968: Memory safety bugs fixed in Firefox 83 and Firefox ESR 78.5

Release notes: https://blog.torproject.org/new-release-tor-browser-1005

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    838,565,624 → 838,588,592
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

FYI maintainers: @joachifm @doublec @hax404 @KarlJoad @matejc @offlinehacker @scaredmushroom @thoughtpolice

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104950 run on x86_64-linux 1

1 package built:
  • torbrowser (tor-browser-bundle-bin)

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104950 run on x86_64-darwin 1

@Ma27 Ma27 merged commit aed3de1 into NixOS:master Nov 26, 2020
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 26, 2020
@Ma27
Copy link
Member

Ma27 commented Nov 26, 2020

Thanks! Ported to stable as 7401ac6.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants