Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintainers: add mudrii #104976

Closed
wants to merge 29 commits into from
Closed

maintainers: add mudrii #104976

wants to merge 29 commits into from

Conversation

mudrii
Copy link
Contributor

@mudrii mudrii commented Nov 26, 2020

Motivation for this change

Allow user to contribute to the NixOS pakgs

Things done

Add new User intro the maintainers-list.nix

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@RaghavSood
Copy link
Member

Are you intending to take maintainership of some packages? If so, you should add some commits adding yourself to the maintainer list there

Also note that just being in this file doesn't allow or stop you from contributing - you can open pull requests for any package even if you aren't listed as a maintainer.

Being listed as a maintainer for packages is just a way for the build tooling and other contributors to know who should review a pull request.

@mudrii
Copy link
Contributor Author

mudrii commented Nov 26, 2020

Yes I will take pulumi and will separate plugins in a diff package

@mudrii mudrii changed the title add new user as maintainer into maintainers-list.nix maintainers: add mudrii Nov 26, 2020
mudrii
mudrii commented Nov 26, 2020
View reviewed changes
Copy link
Contributor Author

@mudrii mudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title change and commit message

vbgl and others added 22 commits November 26, 2020 16:26
@vbgl @mudrii
ocamlPackages.duff: use Dune 2
281cabf
@vbgl @mudrii
ocamlPackages.tuntap: use Dune 2
e9f425c
@vbgl @mudrii
ocamlPackages.randomconv: use Dune 2
cfeee78
@vbgl @mudrii
ocamlPackages.mirage-stack: use Dune 2
38f12d4
@vbgl @mudrii
ocamlPackages.mirage-protocols: use Dune 2
b839b5c
@vbgl @mudrii
ocamlPackages.mirage-flow: use Dune 2
9a9acc2
@vbgl @mudrii
ocamlPackages.mirage-random: use Dune 2
3b225c6
@vbgl @mudrii
ocamlPackages.eqaf: use Dune 2
fb63bc4
@vbgl @mudrii
ocamlPackages.io-page: use Dune 2
2d44642
@vbgl @mudrii
ocamlPackages.macaddr-{cstruct,sexp}: use Dune 2
dc017b1
@vbgl @mudrii
ocamlPackages.conduit: use Dune 2
6458ea1
@vbgl @mudrii
ocamlPackages.ipaddr: use Dune 2
9fef3ff
@vbgl @mudrii
ocamlPackages.cstruct: 4.0.0 → 5.0.0
3b1f03d
@yrashk @mudrii
framac: 21.1 -> 22.0
cfba805
@penguwin @mudrii
charm: 0.8.4 -> 0.8.5
ec23fff
@deviant @mudrii
icon-lang: 9.5.1 -> 9.5.20i
22f19b6
@r-ryantm @mudrii
fend: 0.1.9 -> 0.1.10
a38c609
@r-ryantm @mudrii
fluent-bit: 1.6.4 -> 1.6.5
d5dc068
@r-ryantm @mudrii
exoscale-cli: 1.20.2 -> 1.21.0
ebe1693
@r-ryantm @mudrii
hyper: 2.1.2 -> 3.0.2
7a06650
@r-ryantm @mudrii
go-jsonnet: 0.16.0 -> 0.17.0
10cfd99
@r-ryantm @mudrii
hey: 0.1.3 -> 0.1.4
b39c98d
r-ryantm and others added 6 commits November 26, 2020 16:26
@r-ryantm @mudrii
gortr: 0.14.6 -> 0.14.7
3fc952c
@bbigras @r-burns
@SuperSandro2000 @mudrii
envchain: init at 1.0.1
3bcc25b 
Co-authored-by: Jon <jonringer@users.noreply.github.com>
Co-authored-by: r-burns <52847440+r-burns@users.noreply.github.com>
Co-authored-by: Sandro Jäckel <sandro.jaeckel@gmail.com>
@mudrii
selenium-server-standalone: 3.6.0 -> 3.141.59
2ccce45
@mudrii
chromedriver: 86.0.4240.22 -> 87.0.4280.20
eaa9a5e
@mudrii
chromium/doc: mention chromedriver when updating
4e78d38
@r-ryantm @mudrii
helmsman: 3.5.1 -> 3.6.2
cfe9be8
@mudrii
Copy link
Contributor Author

mudrii commented Nov 26, 2020

I will close this pull request and will reinitiate new one with all fixes included

@mudrii mudrii closed this Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@mudrii @RaghavSood @SuperSandro2000 @vbgl @yrashk @penguwin @deviant @r-ryantm @bbigras @jonringer