Btw, php-8.0.0 tarballs are now on the mirrors in the expected locations. They haven't released any changelogs yet. But it's worth to start targeting that in this PR.

@etu Should I mark all php80Packages and extensions as broken or should I leave them?

I think it's better to leave them for now, just make sure that the php80 attribute builds with the default set. Then we can test things more and easier when it's cached.

json seems excluded from your default list of extensions, howcome? Is it builtin now or some other reason?

json is now always active as extension

Then we should disable json as extension if it's newer than 8.0 to not cause build errors there :)

So I have built 8.0.0 and included the Build Fix for Opcache from php/php-src@4633e70 ( I guess will be released with 8.0.1)

@etu I have no glue how to remove json only in php80 attribute 🙈 . Can you help me here?

I have no glue how to remove json only in php80 attribute see_no_evil . Can you help me here?

That's easy!

{ name = "json"; enable = lib.versionOlder php.version "8.0"; }

Done :)

So now things that depends on the json extension is failing, because it's built in and therefore doesn't exist as a separate extension.

Example in couchbase we have this:

{
  internalDeps = [ php.extensions.json ];
}

Thinking we could do something like:

{
  internalDeps = [] ++ lib.optionals (lib.versionOlder php.version "8.0") [ php.extensions.json ];
}

In places where we use php.extensions.json.

I think the perl package handles a situation somewhat similar. Without taking the time to think it through what would happen if we set json = null; for versions 8.0 and above?

@aanderse We can start with optionals, we've used it before.

@shyim Could you add this diff:

diff --git a/pkgs/development/php-packages/couchbase/default.nix b/pkgs/development/php-packages/couchbase/default.nix
index abe4b7efdea..58c276c1a4e 100644
--- a/pkgs/development/php-packages/couchbase/default.nix
+++ b/pkgs/development/php-packages/couchbase/default.nix
@@ -16,7 +16,7 @@ buildPecl {
   configureFlags = [ "--with-couchbase" ];
 
   buildInputs = with pkgs; [ libcouchbase zlib ];
-  internalDeps = [ php.extensions.json ];
+  internalDeps = [] ++ lib.optionals (lib.versionOlder php.version "8.0") [ php.extensions.json ];
   peclDeps = [ php.extensions.igbinary ];
 
   patches = [
diff --git a/pkgs/development/php-packages/redis/default.nix b/pkgs/development/php-packages/redis/default.nix
index 41ff8f38689..a61ae1194ff 100644
--- a/pkgs/development/php-packages/redis/default.nix
+++ b/pkgs/development/php-packages/redis/default.nix
@@ -7,8 +7,9 @@ buildPecl {
   sha256 = "1cfsbxf3q3im0cmalgk76jpz581zr92z03c1viy93jxb53k2vsgl";
 
   internalDeps = with php.extensions; [
-    json
     session
+  ] ++ lib.optionals (lib.versionOlder php.version "8.0") [
+    json
   ] ++ lib.optionals (lib.versionOlder php.version "7.4") [
     hash
   ];

This will fix the eval, then I think we can merge this and start testing it.

• For Couchbase, the patch above is not sufficient. It needs For PHP 8 support couchbase/php-couchbase#31 but that does not apply because we only have legacy branch of php-couchbase. We probably need to remove couchbase from php80.extensions.

• For blackfire, I pushed c2f1e7b to master.

• For Imagick, we need:

  --- a/pkgs/development/php-packages/imagick/default.nix
  +++ b/pkgs/development/php-packages/imagick/default.nix
  @@ -1,4 +1,4 @@
  -{ buildPecl, lib, pkgs, pcre' }:
  +{ buildPecl, fetchpatch, lib, pkgs, pcre' }:
   
   buildPecl {
     pname = "imagick";
  @@ -6,6 +6,14 @@ buildPecl {
     version = "3.4.4";
     sha256 = "0xvhaqny1v796ywx83w7jyjyd0nrxkxf34w9zi8qc8aw8qbammcd";
   
  +  patches = [
  +    # Fix compatibility with PHP 8.
  +    (fetchpatch {
  +      url = "https://github.com/Imagick/imagick/pull/336.patch";
  +      sha256 = "nuRdh02qaMx0s/5OzlfWjyYgZG1zgrYnAjsZ/UVIrUM=";
  +    })
  +  ];
  +
     configureFlags = [ "--with-imagick=${pkgs.imagemagick.dev}" ];
     nativeBuildInputs = [ pkgs.pkgconfig ];
     buildInputs = [ pcre' ];

We could mark couchbase as broken until there is a upstream version of it

We could mark couchbase as broken until there is a upstream version of it

Yeah, that's fine :)

Should we update extensions that have new version supporting PHP 8 here? E.g. XDebug. Even though it might have API changes like Couchbase 3?

@jtojnar XDebug 3 contains also complete new configuration. Maybe build a own package of it?

xdebug 3.0 is already updated in #105332

@shyim The optional for json in couchbase is still needed to fix eval

And a rebase on master should give us xdebug 3 to test with.

Rebased, added json as optional and marked as broken for php 8

🎉 thanks everyone!