Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spago: get building again with ghc8102 #104164

Merged
merged 1 commit into from Nov 18, 2020
Merged

spago: get building again with ghc8102 #104164

merged 1 commit into from Nov 18, 2020
+20 −3

Conversation

cdepillabout
Copy link
Member

Motivation for this change

The Haskell package set here in nixpkgs recently updated to tracking Stackage Nightly instead of LTS-16. This means that the latest compiler is now to GHC-8.10.2 (not GHC-8.8.4).

I have fixed up the Spago derivation here in nixpkgs to compile with GHC-8.10.2.

cc @f-f because this is based on work he did on purescript/spago#695. Thanks!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout cdepillabout mentioned this pull request Nov 18, 2020
Merged
@cdepillabout
Copy link
Member Author

@GrahamcOfBorg build spago

@maralorn
Copy link
Member

LGTM, thanks!

@maralorn maralorn merged commit f323e4c into NixOS:haskell-updates Nov 18, 2020
@cdepillabout cdepillabout deleted the update-spago branch November 18, 2020 14:07
@f-f
Copy link

f-f commented Jan 3, 2021

@cdepillabout 0.18 is now out, so the derivation could probably be simplified even more 🙂

@cdepillabout
Copy link
Member Author

cdepillabout commented Jan 4, 2021 •
edited

@f-f Thanks for following up here! I actually bumped to 0.18 in this PR: #107448. I was able to simplify a lot of the overrides!

I'll have to remember to cc you when I send PRs bumping spago here in nixpkgs in the future.

@f-f
Copy link

f-f commented Jan 4, 2021

@cdepillabout great to hear! And no worries about not tagging me - I just wanted to followup in here after reading that the build could be simpler with the next version 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cdepillabout @maralorn @f-f