Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inboxer: 1.2.1 -> 1.3.2 #104183

Closed
wants to merge 2 commits into from
Closed

inboxer: 1.2.1 -> 1.3.2 #104183

wants to merge 2 commits into from

Conversation

mgttlinger
Copy link
Member

Fixes missing gtk3 dependency and closes #103878 because this updates
directly to the last version.

Motivation for this change

Dependency on gtk3 was missing even from previous versions of the package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mgttlinger
inboxer: 1.2.1 -> 1.3.2
2940ad3 
Fixes missing gtk3 dependency and closes NixOS#103878 because this updates
directly to the last version.
@mgttlinger
Copy link
Member Author

Made a stupid mistake... Fix imminent...

@mgttlinger
inboxer: use AppImage
1c5ff0a 
go via AppImage to ensure this will work forever onwards as this is
the last ever release
@mgttlinger
Copy link
Member Author

I went via AppImage to ensure the package will work in future releases as well given that the package itself is archived upstream and will not have any further releases.

@FRidh FRidh mentioned this pull request Nov 23, 2020
Closed
@FRidh
Copy link
Member

FRidh commented Nov 23, 2020 •
edited

From the README

As you know Google is going to take down Inbox service.

This project is not maintained anymore. Since Inbox is closed this project has to be closed as well. It just cannot operate normally without Inbox.

I think we should remove it instead.

@mgttlinger
Copy link
Member Author

mgttlinger commented Nov 24, 2020 •
edited

I think we should remove it instead.

What is the benefit of that? The program itself warns the user that it now uses gmail instead of inbox and the package will not have further maintenance effort, right?

@mgttlinger mgttlinger mentioned this pull request Nov 26, 2020
Closed
@SuperSandro2000
Copy link
Member

This project is not maintained anymore. This project doesn't implement Inbox desktop experience, it just used to use Inbox web version packaged as a desktop app. Since Inbox is closed this project has to be closed as well. It just cannot operate normally without Inbox.

See denysdovhan/inboxer#101

What is the benefit of that?

It keeps nixpkgs clean of packages which definitely are not going to work cause they are broken.

The program itself warns the user that it now uses gmail instead of inbox and the package will not have further maintenance effort, right?

The project was about using Inbox as a desktop program which it can't do anymore. It would only make sense to remove it.

@mgttlinger mgttlinger mentioned this pull request Dec 1, 2020
Merged
mgttlinger added a commit to mgttlinger/nixpkgs that referenced this pull request Dec 1, 2020
@mgttlinger
inboxer: remove
7eff08a 
as discussed in NixOS#104183 inboxer shall be removed.
Closes NixOS#104183
@mgttlinger mgttlinger mentioned this pull request Dec 1, 2020
Merged
10 tasks
@SuperSandro2000
Copy link
Member

Superseded by #105613

@mgttlinger mgttlinger deleted the inboxer-fixgrade branch December 1, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mgttlinger @FRidh @SuperSandro2000