pop-os-shell: init at 1.1.0 #104160

remunds · 2020-11-18T12:56:45Z

Motivation for this change

pop-os-shell version 1.0.0 was released 20 days ago. Now it's time to be a package :)
This is my first pr, so please tell me, if something is wrong :)

Things done

pkgs/desktops/gnome-3/extensions/pop-os-shell/default.nix

maintainers/maintainer-list.nix

pkgs/desktops/gnome-3/extensions/pop-os-shell/default.nix

jtojnar · 2020-11-19T14:10:57Z

pkgs/desktops/gnome-3/extensions/pop-os-shell/default.nix

+
+  meta = with stdenv.lib; {
+    description = "Keyboard-driven layer for GNOME Shell";
+    license = licenses.gpl3;


gpl3 is unclear, use gpl3Plus or gpl3Only. See https://discourse.nixos.org/t/lib-licenses-gpl3-co-are-now-deprecated/8206 for more details.

I'm not entirely sure, which version to use. The license can be found here: https://github.com/pop-os/shell/blob/master/LICENSE. Also on the web i could not really identify what the difference is between gpl3-only and gpl3+. Can you tell me what we have here? @jtojnar

Usually, the precise license is listed in README, but that is not the case here. Try asking on the upstream issue tracker. Example: rime/ibus-rime#107

The license is here

That is just license terms, it needs to be explicitly specified whether the copyright owner allows using latter versions of the license, see the GNU links in the Discourse threads.

IIRC if not listed explicitly it should be GPL3 only, shouldn't it?

Yes, that is all that can be inferred without any more info. Though people often intend -or-later so it does not hurt to ask.

jtojnar · 2020-11-19T14:13:31Z

cc #92769 (@mogorman @Technical27 @operator-name)

buckley310 · 2020-11-20T15:23:15Z

This looks like it might be a duplicate of #102150

jtojnar · 2020-11-20T15:35:04Z

Oh, right. I was certain that we already had a PR open but could not find it with GitHub search 🤷‍♀️

jtojnar · 2020-11-20T15:36:51Z

pkgs/desktops/gnome-3/extensions/pop-os-shell/default.nix

+
+  nativeBuildInputs = [ glib nodePackages.typescript ];
+
+  makeFlags = [ "INSTALLBASE=$(out)/share/gnome-shell/extensions" ];


This one is nicer in that it does not abuse DESTDIR.

amaxine · 2020-11-21T20:03:36Z

Oh, neat to see someone get around to packaging this! I've had a commit sitting around waiting for a 1.0 release that might help a bit - I see this doesn't install the glib schema or set the uuid like other gnome extensions.

Also, it might be nice to also package pop-shell-shortcuts (https://github.com/pop-os/shell-shortcuts) to go with it, I believe otherwise the extension will try to open a website with the shortcuts.

Here's my commit for pop-shell that does both things I mentioned: https://github.com/maxeaubrey/nixpkgs/commit/e46df8ddff5facaf57b86e5e7d5be189000e15a1
And here's pop-shell-shortcuts: https://github.com/maxeaubrey/nixpkgs/commit/5c14f15e6a2bfc9b6a11457ccb048a3668f10259

jtojnar · 2020-11-21T20:16:19Z

@maxeaubrey Looking at the source code, it should install schemas:

https://github.com/pop-os/shell/blob/1.0.0/Makefile#L74
https://github.com/pop-os/shell/blob/1.0.0/Makefile#L43

remunds · 2020-11-21T21:30:05Z

@maxeaubrey I had uuid set first, but i was advised to remove it if it is unnecessary.
Regarding pop-shell-shortcuts: I haven't had the problem with the website opening up and currently am using the package without shell-shortcuts. But maybe it's a good thing. Maybe putting it up as a second package is a good idea.

amaxine · 2020-11-21T21:50:08Z

@remunds Oh, I guess uuid is obsolete now? 🤷‍♀️ Fair enough.

@jtojnar I had problems with the schema being missing and the extension not working correctly otherwise, but I cannot reproduce right now. Soz, what I said can be ignored on that.

mmstick · 2020-12-21T19:19:13Z

I would recommend submitting patches upstream for locating the system path if the default GLib subprocess launcher can't find the binaries in your system path. You may add additional search paths with a subprocess launcher. There are a couple areas in Pop Shell that call out gjs, including some of the default plugins which are gjs scripts.

jtojnar · 2020-12-21T19:35:45Z

@mmstick The point of Nix is that there is not system path – every package is self-contained and hardcodes paths to everything it needs (in theory anyway). For some things like script shebangs, we have tooling that hardcodes the correct path but for exec calls in code, a more manual approach is required.

mmstick · 2020-12-21T19:38:39Z

The code that manually calls upon gjs can be changed to make use of the shebang line.

jtojnar · 2020-12-21T19:44:09Z

Right, that would be better for us too, we did the same with GSConnect. @remunds are you able to submit such patch upstream?

ymarkus · 2020-12-22T09:42:02Z

I've found another issue, although I'm not sure if it's maybe only on my end:
Deactivating "Show window titles" doesn't hide title bars.

benneti · 2020-12-22T09:46:53Z

This one is probably due to using Wayland where this is not supported upstream.

remunds · 2020-12-22T11:19:05Z

@jtojnar I will have a look at that later that day, but I am not sure whether I am capable enough. I'll let you know. Do I understand it right that the current approach is to create a patch that puts the shebang #!/usr/bin/env gjs in every file that needs it and then somehow modify the way those files are called?

@ymarkus that works for me.

jtojnar · 2020-12-22T11:21:37Z

@remunds Yes, that is correct. The files need to be invoked as scripts. Also, for that to work, you will need to make them executable if they are not already.

remunds · 2020-12-22T15:31:05Z

I'll give that a try, thanks :)

remunds · 2020-12-22T15:32:18Z

I was able to get the "floating window exception"-window with the other approach though.

remunds · 2020-12-22T15:42:38Z

Now its just the active hint color that doesn't work. Does anyone have an idea?

pkgs/desktops/gnome-3/extensions/pop-os-shell/fix-gjs.patch

pkgs/desktops/gnome-3/extensions/pop-os-shell/default.nix

hmenke · 2021-04-23T08:58:44Z

I've been using this for a few weeks now (updated to 1.2.0 though) on NixOS 20.09 under GNOME 3.36.5 Wayland and apart from the known upstream Wayland wonkiness, this actually works quite nicely.

hpfr · 2021-04-23T14:41:58Z

Tangentially related in case anyone is interested: https://blog.system76.com/post/648371526931038208/cosmic-to-arrive-in-june-release-of-popos-2104

https://github.com/pop-os/cosmic

It has pop-shell as a dependency.

timstott · 2021-05-08T16:52:13Z

pkgs/desktops/gnome-3/extensions/pop-os-shell/default.nix

+{ stdenv, fetchFromGitHub, nodePackages, glib, substituteAll, gjs }:
+
+stdenv.mkDerivation rec {
+  pname = "pop-os-shell";


🙋 Having looked inside pkgs/desktops/gnome-3/extensions, it appears all extensions are prefixed with gnome-shell-extension-, what are your thoughts on renaming?

Suggested change

pname = "pop-os-shell";

pname = "gnome-shell-extension-pop-os-shell";

stale · 2021-11-09T19:20:21Z

I marked this as stale due to inactivity. → More info

genofire · 2021-12-02T17:41:43Z

Solved in #147542 - i believe we could close this PR now.
Maybe you add yourself to maintainers ;)

ofborg bot added 6.topic: GNOME 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 18, 2020

remunds force-pushed the pop-os-shell branch from 1cc77b6 to 5cb0c96 Compare November 18, 2020 13:10

SuperSandro2000 reviewed Nov 18, 2020

View reviewed changes

pkgs/desktops/gnome-3/extensions/pop-os-shell/default.nix Outdated Show resolved Hide resolved

pkgs/desktops/gnome-3/extensions/pop-os-shell/default.nix Outdated Show resolved Hide resolved

remunds force-pushed the pop-os-shell branch from 5cb0c96 to 27407bf Compare November 18, 2020 23:43

jonringer reviewed Nov 19, 2020

View reviewed changes

remunds force-pushed the pop-os-shell branch 2 times, most recently from aeaa714 to 38f1bd9 Compare November 19, 2020 12:55

jtojnar reviewed Nov 19, 2020

View reviewed changes

remunds force-pushed the pop-os-shell branch from 38f1bd9 to 523fb0c Compare November 19, 2020 23:43

remunds mentioned this pull request Nov 20, 2020

Correct gpl3 license for nix package manager pop-os/shell#738

Closed

jtojnar reviewed Nov 20, 2020

View reviewed changes

remunds force-pushed the pop-os-shell branch from 523fb0c to f20b2c3 Compare December 21, 2020 14:05

maintainers: add remunds

b3f018e

ofborg bot added the 2.status: merge conflict label Dec 21, 2020

remunds force-pushed the pop-os-shell branch from f20b2c3 to c3612da Compare December 21, 2020 14:10

remunds changed the title ~~pop-os-shell: init at 1.0.0~~ pop-os-shell: init at 1.1.0 Dec 21, 2020

ofborg bot removed the 2.status: merge conflict label Dec 21, 2020

pop-os-shell: init at 1.1.0

e9d87b0

this one does not work

e210e98

floatingwindow-exceptions work

b6bc8be

jtojnar reviewed Dec 22, 2020

View reviewed changes

pkgs/desktops/gnome-3/extensions/pop-os-shell/fix-gjs.patch Outdated Show resolved Hide resolved

jtojnar reviewed Dec 22, 2020

View reviewed changes

pkgs/desktops/gnome-3/extensions/pop-os-shell/default.nix Outdated Show resolved Hide resolved

jtojnar reviewed Dec 22, 2020

View reviewed changes

pkgs/desktops/gnome-3/extensions/pop-os-shell/default.nix Show resolved Hide resolved

color switch still not working

b4f8e01

timstott reviewed May 8, 2021

View reviewed changes

SuperSandro2000 added the 2.status: merge conflict label May 8, 2021

Icy-Thought mentioned this pull request Jun 23, 2021

Pop Shell (twm GNOME extension) #127952

Closed

ratsclub mentioned this pull request Jul 18, 2021

Package request: Pop shell (Pop!_OS's tiling windows manager extension for GNOME shell) #92769

Closed

Enzime mentioned this pull request Nov 3, 2021

Package the (Pop!_OS) COSMIC Desktop Environment #144411

Closed

12 tasks

stale bot added the 2.status: stale label Nov 9, 2021

genofire mentioned this pull request Nov 26, 2021

gnomeExtensions.pop-shell: init #147542

Merged

13 tasks

stale bot removed the 2.status: stale label Dec 2, 2021

Synthetica9 closed this Dec 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pop-os-shell: init at 1.1.0 #104160

pop-os-shell: init at 1.1.0 #104160

remunds commented Nov 18, 2020 •

edited

Loading

jtojnar Nov 19, 2020

remunds Nov 19, 2020

jtojnar Nov 19, 2020 •

edited

Loading

mmstick Nov 20, 2020

jtojnar Nov 20, 2020

ymarkus Dec 21, 2020

jtojnar Dec 21, 2020

jtojnar commented Nov 19, 2020

buckley310 commented Nov 20, 2020

jtojnar commented Nov 20, 2020

jtojnar Nov 20, 2020

amaxine commented Nov 21, 2020 •

edited

Loading

jtojnar commented Nov 21, 2020 •

edited

Loading

remunds commented Nov 21, 2020

amaxine commented Nov 21, 2020

mmstick commented Dec 21, 2020

jtojnar commented Dec 21, 2020

mmstick commented Dec 21, 2020

jtojnar commented Dec 21, 2020

ymarkus commented Dec 22, 2020

benneti commented Dec 22, 2020

remunds commented Dec 22, 2020

jtojnar commented Dec 22, 2020

remunds commented Dec 22, 2020

remunds commented Dec 22, 2020

remunds commented Dec 22, 2020

hmenke commented Apr 23, 2021

hpfr commented Apr 23, 2021

timstott May 8, 2021

stale bot commented Nov 9, 2021

genofire commented Dec 2, 2021


		nativeBuildInputs = [ glib nodePackages.typescript ];

		makeFlags = [ "INSTALLBASE=$(out)/share/gnome-shell/extensions" ];

	pname = "pop-os-shell";
	pname = "gnome-shell-extension-pop-os-shell";

pop-os-shell: init at 1.1.0 #104160

pop-os-shell: init at 1.1.0 #104160

Conversation

remunds commented Nov 18, 2020 • edited Loading

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jtojnar Nov 19, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jtojnar commented Nov 19, 2020

buckley310 commented Nov 20, 2020

jtojnar commented Nov 20, 2020

Choose a reason for hiding this comment

amaxine commented Nov 21, 2020 • edited Loading

jtojnar commented Nov 21, 2020 • edited Loading

remunds commented Nov 21, 2020

amaxine commented Nov 21, 2020

mmstick commented Dec 21, 2020

jtojnar commented Dec 21, 2020

mmstick commented Dec 21, 2020

jtojnar commented Dec 21, 2020

ymarkus commented Dec 22, 2020

benneti commented Dec 22, 2020

remunds commented Dec 22, 2020

jtojnar commented Dec 22, 2020

remunds commented Dec 22, 2020

remunds commented Dec 22, 2020

remunds commented Dec 22, 2020

hmenke commented Apr 23, 2021

hpfr commented Apr 23, 2021

Choose a reason for hiding this comment

stale bot commented Nov 9, 2021

genofire commented Dec 2, 2021

remunds commented Nov 18, 2020 •

edited

Loading

jtojnar Nov 19, 2020 •

edited

Loading

amaxine commented Nov 21, 2020 •

edited

Loading

jtojnar commented Nov 21, 2020 •

edited

Loading