Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gst-plugins-bad-1.18.0: fix build #104182

Merged
merged 3 commits into from Nov 18, 2020
Merged

gst-plugins-bad-1.18.0: fix build #104182

merged 3 commits into from Nov 18, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Nov 18, 2020

Motivation for this change

Fixes #104130

cc @Mic92 @anna328p

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Nov 18, 2020

@GrahamcOfBorg build gst_all_1.gst-plugins-bad

@Mic92 Mic92 merged commit 6625284 into NixOS:master Nov 18, 2020
@ajs124 ajs124 deleted the fix/gst-plugins-bad branch November 18, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gst-plugins-bad-1.18.0 does not build on x86_64-linux
2 participants
@ajs124 @Mic92