Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snallygaster: init at 0.0.9 #104156

Closed
wants to merge 3 commits into from
Closed

snallygaster: init at 0.0.9 #104156

wants to merge 3 commits into from

Conversation

veehaitch
Copy link
Member

Motivation for this change

Finds file leaks and other security problems on HTTP servers. Github: https://github.com/hannob/snallygaster

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veehaitch
Copy link
Member Author

veehaitch commented Nov 18, 2020 •
edited

Well, apparently this is a duplicate of #104126 🙃 feel free to close this if it gets merged

@SuperSandro2000
Copy link
Member

I merged #104126 because we don't need to run the lint tests and add two modules for that.

@veehaitch
Copy link
Member Author

I merged #104126 because we don't need to run the lint tests and add two modules for that.

Perfectly fine for me, thanks! On the other hand, having those two packages available within Nix isn't a disadvantage per se. Also, if someone wants to contribute to the snallygaster project it is useful to have them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veehaitch @SuperSandro2000