Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python2Packages.bayesian-optimization: disable for py2 #104186

Merged
merged 1 commit into from Nov 19, 2020
Merged

python2Packages.bayesian-optimization: disable for py2 #104186

merged 1 commit into from Nov 19, 2020

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

Source code now contains python3 only syntax

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

do you mind changing the commit to be:

python2Packages.bayesian-optimization: disable for py2

remove gives the impression that the package was removed altogether.

@freezeboy freezeboy changed the title python2Packages.bayesian-optimization: remove python2Packages.bayesian-optimization: disable for py2 Nov 18, 2020
@freezeboy
Copy link
Contributor Author

Done

jonringer
jonringer approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 104186 1

@jonringer jonringer merged commit 9896989 into NixOS:master Nov 19, 2020
@freezeboy freezeboy deleted the remove-bayesian-optimization branch November 19, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freezeboy @jonringer