Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreak appdaemon #104173

Merged
merged 2 commits into from Nov 18, 2020
Merged

Unbreak appdaemon #104173

merged 2 commits into from Nov 18, 2020

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

Upstream update, they have a lot of version constraints, I kept some and relaxed others, as it is python, I guess the only way to be sure everything is working correclty is with a full install, it someone has de test platform for it.

In particular, I replaced the azure==4.0.0 with a split of azure-* python modules, I am not sure how safe it is as I don't use azure.

They rely on a lot of "old" releases of their dependencies

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from peterhoeg and dotlambda November 18, 2020 15:19
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104173 run on x86_64-darwin 1

1 package failed to build:
  • appdaemon
2 packages built:
  • python37Packages.sockjs
  • python38Packages.sockjs

@freezeboy
Copy link
Contributor Author

Can you give more details on the problem please?
locally it looks ok on my side

@SuperSandro2000
Copy link
Member

False negative again...

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104173 run on x86_64-linux 1

3 packages built:
  • appdaemon
  • python37Packages.sockjs
  • python38Packages.sockjs

jonringer
jonringer approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 104173 1

3 packages built:
  • appdaemon
  • python37Packages.sockjs
  • python38Packages.sockjs

@jonringer jonringer merged commit 5dea442 into NixOS:master Nov 18, 2020
@freezeboy freezeboy deleted the unbreak-appdaemon branch November 18, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@freezeboy @SuperSandro2000 @jonringer