Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.kaggle: unbreak, removing useless slugify dep #104178

Merged
merged 1 commit into from Nov 19, 2020
Merged

python3Packages.kaggle: unbreak, removing useless slugify dep #104178

merged 1 commit into from Nov 19, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Nov 18, 2020 •
edited

Motivation for this change

Very strangely upstream depends on both python-slugify and slugify.
The second is quite old, so I removed this one

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from cdepillabout November 18, 2020 16:17
cdepillabout
cdepillabout reviewed Nov 19, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe someone familiar with the Python ecosystem (like @FRidh?) could take a look at this and comment on whether this additional --replace makes sense?

Also, @freezeboy, if you use kaggle, please feel free to add yourself as a maintainer.

jonringer
jonringer approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 104178 1

3 packages built:
  • kaggle (python38Packages.kaggle)
  • python27Packages.kaggle
  • python37Packages.kaggle

@jonringer jonringer merged commit b5a2e19 into NixOS:master Nov 19, 2020
@freezeboy
Copy link
Contributor Author

Hi,

Normally, the replace calls stick to close enough versions, but yes a double check will be better.

I don't use kaggle myself, i took the hydra failing jobs and started to unbreak what I could

@SuperSandro2000
Copy link
Member

Maybe someone familiar with the Python ecosystem (like @FRidh?) could take a look at this and comment on whether this additional --replace makes sense?

Also, @freezeboy, if you use kaggle, please feel free to add yourself as a maintainer.

Slugify is python 2 only. I assume the python 3 version is python-slugify. Kaggle/kaggle-api#299

@freezeboy freezeboy deleted the unbreak-kaggle branch November 19, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout left review comments

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@freezeboy @SuperSandro2000 @cdepillabout @jonringer