Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ebook2cw: 0.8.2 -> 0.8.3 #104187

Merged
merged 1 commit into from Nov 23, 2020
Merged

ebook2cw: 0.8.2 -> 0.8.3 #104187

merged 1 commit into from Nov 23, 2020

Conversation

RaghavSood
Copy link
Member

Motivation for this change

#104048

The original upstream seems migrated to git from svn

As there is a new version available, I also updated it along with fixing the src

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from earldouglas November 18, 2020 17:34
@RaghavSood
Copy link
Member Author

Result of nixpkgs-review pr 104187 1

1 package built:
  • ebook2cw

@RaghavSood RaghavSood merged commit 8e48857 into NixOS:master Nov 23, 2020
@RaghavSood RaghavSood deleted the ebook2cw/src branch November 23, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earldouglas earldouglas earldouglas approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RaghavSood @earldouglas