Result of nixpkgs-review pr 105110 run on x86_64-linux 1

For some reason, Git created a new branch with the same name for the new commits.
EDIT: I can't get the commits to split, sorry.

A few comments:

• (tiny nit) 2-space indentation is more common in nixpkgs :)
• For open-source packages we prefer to have them built from source rather than using binary releases; Packaging Gradle-based applications #17342 tracks making this sort of thing easier in nixpkgs. mindustry: init at 99 (and updates) #72306 is an example of doing it "by hand", which is another option. It might not be worth doing in this situation at the moment, though (I'm sort of 50/50 on this because fixed-output derivations are a pain)
• The ./bin/kotlin-language-server doesn't run "alone" (it expects java to be on the PATH already) which means your buildInputs isn't really going to help - it isn't actually used in building your package. You should probably remove the buildInputs line, add "makeWrapper" to nativeBuildInputs, and add to your installPhase:

    wrapProgram $out/bin/kotlin-language-server \
      --prefix PATH : ${jre}/bin

Some Git advice for splitting: my advice here is probably to carefully recommit things. If you're using the CLI, the best way (in my opinion, other people will have different advice) is to:

$ git reset --soft HEAD^
# You've now removed the last commit, but the changes are still in the index ready to commit, so commit the maintainer-list first:
$ git commit maintainers/maintainer-list.nix
# ...write a commit message for the maintainer-list.nix file
$ git commit
# ...write a commit message for the rest of the files
$ git push --force-with-lease
# and you're done!

I've fixed the indentation and the wrapping issue, however I was unable to get Gradle (I tried the included wrapper and the Nix package) to build the package.

@SuperSandro2000 I also split the commits using lukegb's suggestion.

Result of nixpkgs-review pr 105110 run on x86_64-linux 1

@enderger Please fix the merge conflict.

I've resolved it.

Please do not merge master into PRs. Please resolve that cleanly.

Hey, sorry for dropping this. I was quite naive when it comes to Git when I made this PR. I may try redoing this package at some point, but I'll close the PR since tit is hopelessly out-of-date.