Skip to content

shotcut: use qt-5.15, rework #105077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2020
Merged

shotcut: use qt-5.15, rework #105077

merged 1 commit into from
Nov 27, 2020
+57 −18

Conversation

woffs
Copy link
Contributor

@woffs woffs commented Nov 26, 2020

Motivation for this change

Enable LADSPA audio plugins, which never worked, and clean up things a bit. Review is appreciated for I have not much to do with Qt :-)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@woffs
shotcut: use qt-5.15, rework

Verified

This commit was signed with the committer’s verified signature. The key has expired.
andir Andreas Rammhold
GPG key ID: E432E410B5E48C86
Expired
Verified
Learn about vigilant mode
05440fd 
- use qt-5.15 for shotcut
- use qt mkDerivation for mlt/qt5
- use only mlt/qt5 for shotcut (libmlt -> mlt.dev)
- fix enabling ladspa (configure needs `which`), closes NixOS#47440
@ofborg ofborg bot requested review from cillianderoiste and peti November 26, 2020 20:52
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Nov 26, 2020
@Lassulus
Copy link
Member

Result of nixpkgs-review pr 105077 1

6 packages built:
  • kdenlive (kdeApplications.kdenlive ,libsForQt5.kdenlive)
  • mlt-qt5 (libsForQt5.mlt)
  • libsForQt512.kdenlive
  • libsForQt512.mlt
  • libsForQt514.kdenlive
  • libsForQt514.mlt

@Lassulus
Copy link
Member

huh, weirdly it didn't build shotcut with nix-review

@woffs
Copy link
Contributor Author

woffs commented Nov 26, 2020

Result of nixpkgs-review pr 105077 1

6 packages built:

  • kdenlive (kdeApplications.kdenlive ,libsForQt5.kdenlive)
  • mlt-qt5 (libsForQt5.mlt)
  • libsForQt512.kdenlive
  • libsForQt512.mlt
  • libsForQt514.kdenlive
  • libsForQt514.mlt

Fast machine! At least it compiles, fine. It would be cool if someone checked if kdenlive still works as expected (video export, filters), as I only tested shotcut.

@woffs
Copy link
Contributor Author

woffs commented Nov 26, 2020

x86_64:
1 package marked as broken and skipped:
synfigstudio

7 packages built:
kdenlive mlt-qt5 libsForQt512.kdenlive libsForQt512.mlt libsForQt514.kdenlive libsForQt514.mlt shotcut

@Lassulus Lassulus merged commit b181c63 into NixOS:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus

@SuperSandro2000 SuperSandro2000

@cillianderoiste cillianderoiste

@peti peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shotcut does not find LADSPA plugins
3 participants
@woffs @Lassulus @SuperSandro2000