zig: 0.6.0 -> 0.7.1 #105086
zig: 0.6.0 -> 0.7.1 #105086
Conversation
|
Looking forward to this. |
I think you have hit a legitimate bug that is fixed in the 0.7.x branch. Hopefully 0.7.1 should be released in a week or two. But I personally don't think you need to get the zig test suite passing to package up the release (although I understand if that is policy). |
| ''; | ||
|
|
||
| checkPhase = '' | ||
| runHook preCheck | ||
| ./zig test $src/test/stage1/behavior.zig | ||
| ./zig build -Dskip-non-native \ |
There was a problem hiding this comment.
why not ./zig build test -Dskip-non-native ? It runs all the tests below.
also you can speed things up considerably if you are willing to skip release tests: -Dskip-release
There was a problem hiding this comment.
This was still a WIP PR; I split the tests up line-by-line because I was planning to disable them to track down which one was failing, and I needed to transfer them from one computer to another. I'm not sure on the general NixOS policy on skipping release tests, hence I left them in. IMO it's probably worth running them because binary caches exist and it feels safer.
|
At this point I think given there are only 5 more issues in the Zig 0.7.1 milestone, and seeing that the test failure is due to a bug that's been fixed in master, I'll take another look when 0.7.1 is out. |
jshholland
force-pushed
the
update-zig
branch
from
4a1fbd9
to
2dae0a5
Compare
|
0.7.1 has now been released, and I have managed to successfully build with the current changes. Ready for review and merge from my end here now. |
jshholland
force-pushed
the
update-zig
branch
from
2dae0a5
to
6ece880
Compare
|
@jshholland Can you fix the merge conflict? |
Currently, the test suite fails with the following output: build.log
I'm not sure how to debug this; I was going to start by doing a binary search on the test suite since I split them out in commit
4a1fbd9 but I haven't got to this yet.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)