Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ammonite: 2.2.0 -> 2.3.8 #105115

Merged
merged 2 commits into from Nov 27, 2020
Merged

ammonite: 2.2.0 -> 2.3.8 #105115

merged 2 commits into from Nov 27, 2020

Conversation

JesusMtnez
Copy link
Contributor

Motivation for this change

Bump ammonite to latest release 2.3.8.

Updated using:

nix-shell maintainers/scripts/update.nix --argstr package ammonite_2_12
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from NeQuissimus November 27, 2020 05:51
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105115 run on x86_64-linux 1

2 packages built:
  • ammonite (ammonite_2_13)
  • ammonite_2_12

@bbjubjub2494
Copy link
Member

bbjubjub2494 commented Nov 27, 2020 •
edited

Both packages (2.12 and 2.13) build but won't execute. Might be a shell quoting problem?

Error: Could not find or load main class ammonite.Main --no-remote-logging
Caused by: java.lang.ClassNotFoundException: ammonite.Main --no-remote-logging

Edit: probably to do with line 26

@NeQuissimus
Copy link
Member

NeQuissimus commented Nov 27, 2020 •
edited

@JesusMtnez Thank you, I fixed the argument issue.
nix-build -A ammonite.tests ;)
Let's let @ofborg do its thing and then we can merge.

@ofborg ofborg bot requested a review from NeQuissimus November 27, 2020 15:11
@NeQuissimus NeQuissimus merged commit f5edf8a into NixOS:master Nov 27, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105115 run on x86_64-darwin 1

2 packages built:
  • ammonite (ammonite_2_13)
  • ammonite_2_12

@JesusMtnez JesusMtnez deleted the ammonite branch February 22, 2021 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JesusMtnez @SuperSandro2000 @bbjubjub2494 @NeQuissimus