Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] libxml2: fix CVE-2020-24977 #105088

Merged
merged 1 commit into from Nov 27, 2020
Merged

[staging] libxml2: fix CVE-2020-24977 #105088

merged 1 commit into from Nov 27, 2020

Conversation

mweinelt
Copy link
Member

Motivation for this change

Fixes an out-of-bounds read when using xmllint with the --htmlout
parameter.

Fixes: CVE-2020-24977

https://nvd.nist.gov/vuln/detail/CVE-2020-24977
https://gitlab.gnome.org/GNOME/libxml2/commit/50f06b3efb638efb0abd95dc62dca05ae67882c2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 26, 2020
mweinelt
mweinelt commented Nov 26, 2020
View reviewed changes
pkgs/development/libraries/libxml2/default.nix
name = "CVE-2019-20388.patch";
url = "https://gitlab.gnome.org/GNOME/libxml2/commit/6088a74bcf7d0c42e24cff4594d804e1d3c9fbca.patch";
sha256 = "070s7al2r2k92320h9cdfc2097jy4kk04d0disc98ddc165r80jl";
})
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by patch sorting

@ofborg ofborg bot requested a review from edolstra November 26, 2020 22:44
@mweinelt
libxml2: fix CVE-2020-24977
84d79a9 
Fixes an out-of-bounds read when using xmllint with the --htmlout
parameter.

Fixes: CVE-2020-24977
@mweinelt mweinelt changed the base branch from master to staging November 26, 2020 23:30
@mweinelt mweinelt changed the title libxml2: fix CVE-2020-24977 [staging] libxml2: fix CVE-2020-24977 Nov 26, 2020
@ofborg ofborg bot requested a review from edolstra November 26, 2020 23:56
@mweinelt mweinelt requested a review from FRidh November 27, 2020 01:10
@FRidh FRidh merged commit ab61f16 into NixOS:staging Nov 27, 2020
@mweinelt mweinelt deleted the libxml2 branch November 27, 2020 19:38
@mweinelt mweinelt mentioned this pull request Nov 27, 2020
Merged
10 tasks
@mweinelt mweinelt removed the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

@lukegb lukegb lukegb approved these changes

@chkno chkno chkno approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mweinelt @mmilata @lukegb @chkno @FRidh