fribidi: fix cross #105102
Merged
fribidi: fix cross #105102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flokli
added
the
6.topic: cross-compilation
Ericson2314
approved these changes
Nov 27, 2020
|
I am not sure why this is causing a mass rebuild but please target staging. |
lukegb
approved these changes
Nov 27, 2020
There was a problem hiding this comment.
Before:
$ nix build -f . pkgsCross.aarch64-multiplatform.fribidi
builder for '/nix/store/asld67311lr380gpp02n9f35g04b9iin-fribidi-1.0.10-aarch64-unknown-linux-gnu.drv' failed with exit code 1; last 10 log lines:
Has header "sys/times.h" : YES
Has header "strings.h" : YES (cached)
Configuring config.h using configuration
Has header "stdlib.h" : YES (cached)
Has header "string.h" : YES (cached)
Has header "strings.h" : YES (cached)
gen.tab/meson.build:32:0: ERROR: No build machine compiler for "gen.tab/gen-unicode-version.c"
A full log can be found at /build/fribidi-1.0.10/build/meson-logs/meson-log.txt
[0 built (1 failed), 1 copied (1.1 MiB), 1.1 MiB DL]
error: build of '/nix/store/asld67311lr380gpp02n9f35g04b9iin-fribidi-1.0.10-aarch64-unknown-linux-gnu.drv' failed
After:
$ nix build -f . pkgsCross.aarch64-multiplatform.fribidi
[1 built, 0.0 MiB DL]
Nice!
|
Yes please retarget to staging, then we can merge. |
Meson needs a native compiler to produce some binaries: > gen.tab/meson.build:32:0: ERROR: No build machine compiler for "gen.tab/gen-unicode-version.c"
flokli
force-pushed
the
nixos-cross-fribidi
branch
from
f14c897
to
98b72a7
Compare
|
This now targets staging. Sorry for the delay, was a bit away from computers ;-) |
ofborg
bot
added
10.rebuild-darwin: 2501-5000
and removed
10.rebuild-darwin: 1001-2500
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meson needs a native compiler to produce some binaries:
Tested building
pkgsCross.armv7l-hf-multiplatform.fribidiandpkgsCross.aarch64-multiplatform.fribidiafter this.Motivation for this change
fribidiis needed forsmartmontools, which is part ofnixos/modules/profiles/base.nix. It's also needed by zfs, so this fixes more cross-NixOS things.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)